feat(grid): advanced grid controls#6354
Merged
Merged
Conversation
…to advanced-modal-sample
…to advanced-modal-sample
Contributor
#14226 Bundle Size — 62.64MiB (+0.02%).04ede4d(current) vs 916e8b9 master#14225(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch feat/grid-advanced-modal Project dashboard Generated by RelativeCI Documentation Report issue |
Contributor
Contributor
Author
@balazsbajorics this actually happens on master as well (it's unrelated to the advanced grid popup). |
seanparsons
approved these changes
Sep 13, 2024
ruggi
reviewed
Sep 16, 2024
balazsbajorics
approved these changes
Sep 16, 2024
liady
added a commit
that referenced
this pull request
Dec 13, 2024
This PR adds advanced grid controls: * add inspector modal for advanced controls * justify + Align items - as chain controls * justify + Align content - as dropdowns * adding the ability to unset by clicking on the same button <video src="https://github.com/user-attachments/assets/17fc9368-ad77-4802-9f50-faa0c798136a"></video> Reviewers: the main logic is in [`editor/src/components/inspector/controls/advanced-grid-modal.tsx`](https://github.com/concrete-utopia/utopia/pull/6354/files#diff-0c658c76e054ebe3b417768607e4f5b50552cef5825e33d0cf694a966a04bc36) **Manual Tests:** I hereby swear that: - [X] I opened a hydrogen project and it loaded - [X] I could navigate to various routes in Preview mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This PR adds advanced grid controls:
Monosnap.screencast.2024-09-15.18-31-51.mp4
Reviewers: the main logic is in
editor/src/components/inspector/controls/advanced-grid-modal.tsxManual Tests:
I hereby swear that: