Skip to content

keep track of set grid props#6261

Closed
bkrmendy wants to merge 1 commit into
masterfrom
feature/grid-prop-counting
Closed

keep track of set grid props#6261
bkrmendy wants to merge 1 commit into
masterfrom
feature/grid-prop-counting

Conversation

@bkrmendy
Copy link
Copy Markdown
Contributor

@bkrmendy bkrmendy commented Aug 27, 2024

Depends on #6191

Description

This PR adds a utility hook that makes it possible for inspector control section to record whether the component(s) they are setting are set.

Manual Tests

I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Preview mode

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 27, 2024

Try me

@relativeci
Copy link
Copy Markdown

relativeci Bot commented Aug 27, 2024

#13943 Bundle Size — 62.5MiB (~+0.01%).

52c112a(current) vs 916e8b9 master#13941(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#13943
     Baseline
#13941
Regression  Initial JS 45.64MiB(~+0.01%) 45.63MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.54% 21.51%
No change  Chunks 30 30
No change  Assets 33 33
No change  Modules 4375 4375
No change  Duplicate Modules 519 519
No change  Duplicate Code 31.64% 31.64%
No change  Packages 472 472
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13943
     Baseline
#13941
Regression  JS 62.49MiB (~+0.01%) 62.49MiB
Improvement  HTML 11.05KiB (-0.33%) 11.09KiB

Bundle analysis reportBranch feature/grid-prop-countingProject dashboard


Generated by RelativeCIDocumentationReport issue

@ruggi
Copy link
Copy Markdown
Contributor

ruggi commented Oct 3, 2024

closed in favor of #6468

@ruggi ruggi closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants