Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile-dev, update Codespaces readme #1243

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

pjanik
Copy link
Member

@pjanik pjanik commented Mar 18, 2024

The Dockerfile-dev was no longer working, so I've made it more similar to the recently updated Dockerfile. The most significant change is switching to Alpine Linux. Essentially, I'm installing the same dependencies as in Dockerfile, plus bash (since Alpine doesn't include it by default, and its absence crashes some dev startup scripts).

I commented out the Google Chrome installation, as it would require some time to learn how to do it on Alpine Linux. However, I did manage to successfully run both docker/dev/run-spec.sh and docker/dev/run-cucumber.sh (although it appears that most of them are skipped). So, I'm wondering if we actually need Chrome at all?

Also, I've removed docker login command from GH Codespaces readme as it's no longer necessary.

Copy link
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. We can figure out the Chrome issue if we need it again.

I'm not sure what the status of the cucumber/jest tests that use selenium is.

@pjanik pjanik merged commit 4914210 into master Mar 18, 2024
10 checks passed
@pjanik pjanik deleted the 187259346-dockerfile-dev-fix branch March 18, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants