Fix Dockerfile-dev, update Codespaces readme #1243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Dockerfile-dev
was no longer working, so I've made it more similar to the recently updatedDockerfile
. The most significant change is switching to Alpine Linux. Essentially, I'm installing the same dependencies as inDockerfile
, plusbash
(since Alpine doesn't include it by default, and its absence crashes some dev startup scripts).I commented out the Google Chrome installation, as it would require some time to learn how to do it on Alpine Linux. However, I did manage to successfully run both
docker/dev/run-spec.sh
anddocker/dev/run-cucumber.sh
(although it appears that most of them are skipped). So, I'm wondering if we actually need Chrome at all?Also, I've removed
docker login
command from GH Codespaces readme as it's no longer necessary.