Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow append in legacy cpp info mockup #12720

Merged

Conversation

jcar87
Copy link
Contributor

@jcar87 jcar87 commented Dec 16, 2022

Changelog: Bugfix: Fix issue to allow appending to objects returned by the legacy build_modules mock object.

(Similar to #12673)

Fixes issue with pybind11 recipe in Conan Center with Conan2:

      cmake_file = os.path.join(cmake_base_path, "pybind11Common.cmake")
        self.cpp_info.set_property("cmake_build_modules", [cmake_file])
        for generator in ["cmake_find_package", "cmake_find_package_multi"]:
            self.cpp_info.components["pybind11_"].build_modules[generator].append(cmake_file)

@czoido czoido added this to the 2.0.0-beta7 milestone Dec 16, 2022
@jcar87 jcar87 marked this pull request as ready for review December 16, 2022 12:11
@czoido czoido merged commit a01b2fe into conan-io:develop2 Dec 16, 2022
@jcar87 jcar87 deleted the bugfix/allow_append_in_legacy_cpp_info_mockup branch December 16, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants