rapidyaml: remove internal c4core #9061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
SSE4
previously approved these changes
Jan 28, 2022
uilianries
previously approved these changes
Feb 2, 2022
recipes/rapidyaml/all/conanfile.py
Outdated
| @@ -88,7 +96,7 @@ def package_info(self): | |||
| self.cpp_info.set_property("cmake_file_name", "ryml") | |||
| self.cpp_info.set_property("cmake_target_name", "ryml::ryml") | |||
| # TODO: create c4core recipe | |||
There was a problem hiding this comment.
Hate dismissing reviews but the comment is now misleading
Suggested change
| # TODO: create c4core recipe |
There was a problem hiding this comment.
Sorry for my late response.
Thank you for pointing out my mistake.
I will fix it.
prince-chrismc
approved these changes
Feb 7, 2022
uilianries
approved these changes
Feb 7, 2022
|
All green in build 4 (
|
SSE4
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: rapidyaml/0.3.0
The current recipe in rapidyaml uses the internal c4core.
Since the c4core recipe has been merged into cci, it is time to remove the internal c4core from rapidyaml's recipe.
conan-center hook activated.