Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iir] Add a patch making exception throwing optional #8547

Closed
wants to merge 1 commit into from

Conversation

wouterz
Copy link
Contributor

@wouterz wouterz commented Dec 27, 2021

Specify library name and version: iir1/1.9.0

Through this patch throwing exceptions is made optional; I have also submitted a PR to upstream these changes but in the mean time an update to the repo also seems logical.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Dec 27, 2021

Why not waiting a new version? The patch is huge, it adds a feature, it's not a build fix. Moreover, there should be a new option in conanfile anyway.

@wouterz
Copy link
Contributor Author

wouterz commented Dec 27, 2021

It doesn't break the library build, but it is breaking for no-exception projects using this library. However I do agree that it is also kind of a (big) feature, although the actual changes are only +- 90 lines (rest is padding in the diff).

The main reason for patching on conan, is for speed as Im not sure when a new release of the library is due.

I did forget the conanfile option... I will add this if the PR is considered viable

@SSE4 SSE4 requested a review from uilianries December 28, 2021 06:57
@uilianries
Copy link
Member

I suggest asking to the author for a new release, or at least, a date to understand when we will have it available.

I would not include it on 1.9.0, because it will cause a different behavior from the official release.

If the author don't have a release in mind for now, you can create a custom version like cci.<YYYYMMDD> as documented here.

@SSE4 SSE4 changed the title Add a patch making exception throwing optional [iir] Add a patch making exception throwing optional Jan 10, 2022
@conan-center-bot
Copy link
Collaborator

All green in build 2 (067765b46deab53d5310ed0e11228d8f4b93e3de):

  • iir1/1.9.0@:
    All packages built successfully! (All logs)

@ghost
Copy link

ghost commented Jan 11, 2022

I detected other pull requests that are modifying iir1/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@wouterz
Copy link
Contributor Author

wouterz commented Jan 11, 2022

i have created a new PR #8835 creating a cci bump, so closing this one

@wouterz wouterz closed this Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants