-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libe57format/3.2.0 release #26146
Add libe57format/3.2.0 release #26146
Conversation
acf90d4
to
f90663f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @EstebanDugueperoux2 - please only make the changes required by the PR objetive (adding 3.2.0) - we've had issues with hasty removals of old logic leading to unintended bugs. For the time being, the team will try to take on these clean ups after the PR has been reviewed and if it doesn't cause delays in merging a useful feature.
Hi @jcar87, the issue is that only adding new release make pipeline failed. |
mmm, we can have a look, what was the CI failure in this case?
The removal of the
We keep asking contributors to avoid these kind of changes because we very often see that they are more invasive and have side effects that are not intended, as it seems to be the case here |
b174b30
to
9294a1f
Compare
9294a1f
to
1cfef57
Compare
Hi @jcar87 I have updated recipe to relax replace_in_file with strict=False because "set_warning_as_error()" doesn't exists anymore in recent release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for amending the PR!
Summary
Changes to recipe: libe57format/3.2.0
Motivation
Add 3.2.0 release