Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libe57format/3.2.0 release #26146

Conversation

EstebanDugueperoux2
Copy link
Contributor

Summary

Changes to recipe: libe57format/3.2.0

Motivation

Add 3.2.0 release

@EstebanDugueperoux2 EstebanDugueperoux2 force-pushed the feature/AddLibE57Format3.2.0Release branch from acf90d4 to f90663f Compare December 10, 2024 05:43
@EstebanDugueperoux2 EstebanDugueperoux2 marked this pull request as ready for review December 10, 2024 05:46
Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EstebanDugueperoux2 - please only make the changes required by the PR objetive (adding 3.2.0) - we've had issues with hasty removals of old logic leading to unintended bugs. For the time being, the team will try to take on these clean ups after the PR has been reviewed and if it doesn't cause delays in merging a useful feature.

@EstebanDugueperoux2
Copy link
Contributor Author

Thanks @EstebanDugueperoux2 - please only make the changes required by the PR objetive (adding 3.2.0) - we've had issues with hasty removals of old logic leading to unintended bugs. For the time being, the team will try to take on these clean ups after the PR has been reviewed and if it doesn't cause delays in merging a useful feature.

Hi @jcar87, the issue is that only adding new release make pipeline failed.
And it seems patch done inside the recipe is no more usefull.

@jcar87
Copy link
Contributor

jcar87 commented Jan 28, 2025

Hi @jcar87, the issue is that only adding new release make pipeline failed.

mmm, we can have a look, what was the CI failure in this case?

And it seems patch done inside the recipe is no more usefull.

The removal of the _patch_sources() method is in effect for all already published versions, so it is introducing regressions for pre-existing versions w.rt. POSITION_INDEPENDENT_CODE, and introducing a regression for 3.1.1 by removing the warnings as errors - if this PR were merged, it could cause issues to users of 3.1.1 -

And it seems patch done inside the recipe is no more usefull.

We keep asking contributors to avoid these kind of changes because we very often see that they are more invasive and have side effects that are not intended, as it seems to be the case here

@EstebanDugueperoux2 EstebanDugueperoux2 force-pushed the feature/AddLibE57Format3.2.0Release branch 4 times, most recently from b174b30 to 9294a1f Compare January 28, 2025 18:42
@EstebanDugueperoux2 EstebanDugueperoux2 force-pushed the feature/AddLibE57Format3.2.0Release branch from 9294a1f to 1cfef57 Compare January 28, 2025 18:48
@EstebanDugueperoux2
Copy link
Contributor Author

Hi @jcar87 I have updated recipe to relax replace_in_file with strict=False because "set_warning_as_error()" doesn't exists anymore in recent release.
It was the cause of previous pipeline failures.

Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for amending the PR!

@jcar87 jcar87 merged commit 0e08bfc into conan-io:master Jan 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants