Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asmjit: add version cci.20241216 (for blend2d) #26128

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented Dec 6, 2024

Summary

Changes to recipe: asmjit/cci.20241216

Motivation

To update blend2d, we need to update asmjit.
blend2d/0.11.5 on arm requires latest asmjit due to changing namespace of Inst.

asmjit/asmjit@514a89f
blend2d/blend2d@292c9d3

Details


@toge toge mentioned this pull request Dec 6, 2024
3 tasks
@@ -1,4 +1,6 @@
versions:
"0.0.0.cci.20241125":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs to be cci.20241125, as otherwise it would never evaluate as newer.
0.0.0.cci. should be for new, previously unpublished recipes (@ErniGH or @memsharded may have more context)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly. 0.0.0.cci is to be used when the upstream project never did any previous release, in new packages in ConanCenter that didn't have previous versions published.

In this case, the problem is that the Conan existing package already had cci.2024 versioning, so it seems that in order to be consistent and keep ordering, the cci.2024... should remains instead of the 0.0.0.cci one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcar87 @memsharded
Thank you for your review!
I removed "0.0.0." from version number.

@toge toge changed the title asmjit: add version 0.0.0.cci.20241125 (for blend2d) asmjit: add version cci.20241216 (for blend2d) Dec 31, 2024
Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@jcar87 jcar87 merged commit 56db492 into conan-io:master Dec 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants