Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend test_package code to trigger linkage against upstreams. #25567

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Adnn
Copy link
Contributor

@Adnn Adnn commented Oct 8, 2024

Summary

Changes to recipe: libarchive/[all]

Motivation

This PR extends the test package to reproduce issue #25565

Details

The test_package code calls archive_read_support_filter_all() which triggers linkage against upstreams used to support compression formats.
This should trigger the linker error described in #25565 when building on Windows arch=x86.


@Adnn
Copy link
Contributor Author

Adnn commented Oct 8, 2024

We are happy to also work on actually fixing the issue.

What we currently do locally is to plainly disable patch 0001-zlib-winapi, and things are fine for all our supported environments. Yet before simply adding a commit disabling the patch to this PR, we might need to hear the rationale behind it.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 1 (7f5a228c69a6a42567bb19fd8826e3484cece420):

  • libarchive/3.7.1:
    Built 20 packages out of 22 (All logs)

  • libarchive/3.7.4:
    Built 20 packages out of 22 (All logs)

  • libarchive/3.7.6:
    Built 20 packages out of 22 (All logs)

  • libarchive/3.7.3:
    Built 20 packages out of 22 (All logs)

  • libarchive/3.7.2:
    Built 20 packages out of 22 (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants