Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ouster_sdk: add version 0.13.0 #25556

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jmdaly
Copy link
Contributor

@jmdaly jmdaly commented Oct 7, 2024

Summary

Adding new version of ouster_sdk: ouster_sdk/0.13.0

Motivation

Ouster has released a new version of their C++ SDK for their lidars. I would like to have it in conan-center.

Details

This is just a version bump, no recipe changes.


@conan-center-bot conan-center-bot added the Bump version PR bumping version without recipe modifications label Oct 7, 2024
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

No notable changes in the project build system: ouster-lidar/ouster-sdk@2024070...release-0.13.0

Looks like the git repo was renamed from ouster_examples to ouster-sdk since the last release. Could you update the homepage URL in the recipe accordingly as well, please?

@conan-center-bot conan-center-bot added Failed and removed Bump version PR bumping version without recipe modifications labels Oct 8, 2024
@conan-center-bot

This comment has been minimized.

@jmdaly
Copy link
Contributor Author

jmdaly commented Oct 8, 2024

Looks like the git repo was renamed from ouster_examples to ouster-sdk since the last release. Could you update the homepage URL in the recipe accordingly as well, please?

Nice catch, thanks! I updated homepage to the new URL :)

@ErniGH ErniGH self-assigned this Oct 8, 2024
@valgur
Copy link
Contributor

valgur commented Oct 8, 2024

Also, if you don't mind, could you remove the following lines as well:

            if self.settings.os != "Windows":
                self.requires("xorg/system")
...
            if self.settings.os != "Windows":
                self.cpp_info.components["ouster_viz"].requires.append("xorg::xorg")

I'm not sure why I included this in the recipe. ouster_viz does not appear to be depending on X11 in any way:

@jmdaly
Copy link
Contributor Author

jmdaly commented Oct 8, 2024

Also, if you don't mind, could you remove the following lines as well:

Done :)

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 3 (dbe578dc390b697d93c5186c3fdbfff5a3c360ae):

  • ouster_sdk/0.13.0:
    Built 16 packages out of 22 (All logs)

  • ouster_sdk/0.12.0:
    Built 16 packages out of 22 (All logs)

  • ouster_sdk/0.11.0:
    Built 16 packages out of 22 (All logs)

  • ouster_sdk/0.10.0:
    Built 16 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (dbe578dc390b697d93c5186c3fdbfff5a3c360ae):

  • ouster_sdk/0.10.0:
    Built 7 packages out of 10 (All logs)

  • ouster_sdk/0.13.0:
    Built 7 packages out of 10 (All logs)

  • ouster_sdk/0.11.0:
    Built 7 packages out of 10 (All logs)

  • ouster_sdk/0.12.0:
    Built 7 packages out of 10 (All logs)

Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

url: "https://github.com/ouster-lidar/ouster_example/archive/refs/tags/20240703.tar.gz"
sha256: "aac9f82d8b8376bd11366204a57ab4e2a27e92a1a758238f2d3859e570be4914"
url: "https://github.com/ouster-lidar/ouster-sdk/archive/refs/tags/20240703.tar.gz"
sha256: "7edff33451e99fe094aeafc4c10081d77bfe02d2f2ab16da93a44a5e61473af7"
Copy link
Member

@AbrilRBS AbrilRBS Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same contents, just renamed folder

~/Downloads $ mv 7edff33451e99fe094aeafc4c10081d77bfe02d2f2ab16da93a44a5e61473af7 new.tar.gz
~/Downloads $ mv aac9f82d8b8376bd11366204a57ab4e2a27e92a1a758238f2d3859e570be4914 old.tar.gz
~/Downloads $ diff -q --no-dereference new/ old
~/Downloads $

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(The old links were preserved in our backup-sources mirror)

url: "https://github.com/ouster-lidar/ouster_example/archive/refs/tags/20240425.tar.gz"
sha256: "f4f38f6787021e697633f2c290c95b544af81d388a18cb9f790234d4f592caf0"
url: "https://github.com/ouster-lidar/ouster-sdk/archive/refs/tags/20240425.tar.gz"
sha256: "8141abf4caef8a175a48c35c47bd841b34f8a7d758cb3ad66cf948a7042adbf9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

url: "https://github.com/ouster-lidar/ouster_example/archive/refs/tags/20231031.tar.gz"
sha256: "150482d28930308ef089233f3d4eb15d1330727a167aad3f9b2190078dcecfbf"
url: "https://github.com/ouster-lidar/ouster-sdk/archive/refs/tags/20231031.tar.gz"
sha256: "c45dfd42ff11e171b605ffd0a98d8094ec88ecbbccb923d396e1e73cba7737f3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also same here :)

@AbrilRBS AbrilRBS requested a review from ErniGH October 9, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants