Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turtle: add new version 2.0.0 #25552

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

toge
Copy link
Contributor

@toge toge commented Oct 7, 2024

Summary

Changes to recipe: turtle/2.0.0

Motivation

turtle/2.0.0 requires C++14.

Details

mat007/turtle@v1.3.2...v2.0.0


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Oct 7, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error comes from apple-clang having a default cppstd of gnu98, so we would need to force it to 14.

My recommendation is to use upstream's CMakeLists's to handle the install, and in a generate() method, add the workaround lines of

tc = CMakeToolchain(self)
if not self.settings.compiler.cppstd:
    tc.variables["CMAKE_CXX_STANDARD"] = self._min_cppstd

for versions >= 2.0

Wdyt @toge? :)

@toge toge changed the title turtle: add version 2.0.0 turtle: add new version 2.0.0 Oct 8, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 3 (e90de920a38b8d747e118f6e9d7e2c3cf8ae94e8):

  • turtle/2.0.0:
    Built 5 packages out of 11 (All logs)

  • turtle/1.3.2:
    Built 5 packages out of 11 (All logs)

  • turtle/1.3.1:
    Built 5 packages out of 11 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (e90de920a38b8d747e118f6e9d7e2c3cf8ae94e8):

  • turtle/2.0.0:
    Built 4 packages out of 5 (All logs)

  • turtle/1.3.2:
    Built 4 packages out of 5 (All logs)

  • turtle/1.3.1:
    Built 4 packages out of 5 (All logs)

Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 9, 2024

Oh @toge I didn't catch it's a header-only recipe, good catch updating the test_package!

@conan-center-bot conan-center-bot merged commit 2a357d4 into conan-io:master Oct 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants