Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[symengine] Add version 0.13.0. #25548

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cqc-alec
Copy link
Contributor

@cqc-alec cqc-alec commented Oct 7, 2024

@conan-center-bot conan-center-bot added the Bump version PR bumping version without recipe modifications label Oct 7, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 1 (015d48b6223567cd9dfe2af4586ee1f0d7891ff5):

  • symengine/0.13.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (015d48b6223567cd9dfe2af4586ee1f0d7891ff5):

  • symengine/0.13.0:
    Built 8 packages out of 10 (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

This new minor includes fast float vendorized, not big deal, but we just need to check the licenses first: "https://github.com/symengine/symengine

@cqc-alec
Copy link
Contributor Author

cqc-alec commented Oct 7, 2024

Thank you for your PR!

This new minor includes fast float vendorized, not big deal, but we just need to check the licenses first: "https://github.com/symengine/symengine

Ah, this one? https://github.com/symengine/symengine/blob/0ccc20fea491ba0939768a2d74e590df2c1c2a74/LICENSE#L256

@cqc-alec
Copy link
Contributor Author

cqc-alec commented Oct 9, 2024

Hi @uilianries , is there something I can do to help with this?

@AbrilRBS AbrilRBS self-assigned this Oct 9, 2024
@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 9, 2024

Hi @cqc-alec, Uilian is currently on vacaction, so I'm taking over his PRs for now

I've pushed some improvements to the recipe to modernize it. I've used the new WITH_SYSTEM_FASTFLOAT to ensure that it's not using the vendorized version, and made sure that gmp/boost also works correctly now (-o="&:integer_class=boost" used to fail compilation before this PR)

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bump version PR bumping version without recipe modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants