Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pole 0.5 #25139

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Pole 0.5 #25139

wants to merge 12 commits into from

Conversation

luc-c
Copy link
Contributor

@luc-c luc-c commented Sep 4, 2024

Summary

Changes to recipe: pole/0.5

Motivation

pole is a small library that read and write ole files

Details

Introduction of the library


@CLAassistant
Copy link

CLAassistant commented Sep 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, thanks!

recipes/pole/all/conanfile.py Outdated Show resolved Hide resolved
recipes/pole/all/conanfile.py Show resolved Hide resolved
recipes/pole/all/conanfile.py Show resolved Hide resolved
Comment on lines 41 to 42
deps = CMakeDeps(self)
deps.generate()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this generator if there are no dependencies

recipes/pole/all/conanfile.py Show resolved Hide resolved

# Optional metadata
license = "<Put the package license here>"
author = "<Put your name here> <And your email here>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/cmake_package for what values to actually put here (Or use that template directly!), but author is not a field that should be added to a CCI recipe :)

Suggested change
author = "<Put your name here> <And your email here>"

@@ -0,0 +1,4 @@
sources:
"0.5":
url: "https://github.com/luc-c/Pole/archive/refs/tags/0.5.zip"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is your fork, but I'd like to ask what's the difference with the original https://github.com/otofoto/Pole and why one would be chosen above there other, thanks!

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't meant to approve!

@luc-c
Copy link
Contributor Author

luc-c commented Sep 5, 2024

Some comments, thanks!

Thanks for your feedback!
I'll certainly change my strategy and make a patch on top of the "original" fork!

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

Failure in build 8 (02aba07c0ae39287ba5483bb2aa69de7d7a16653):

  • pole/0.5.4:
    CI failed to create some packages (All logs)

    Logs for packageID 4d887c1c2779c63d2cdd81580698d2e22cb35b29:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=5
    os=Linux
    [options]
    pole:shared=False
    
    [...]
    -- Detecting C compiler ABI info - done
    -- Check for working C compiler: /usr/bin/gcc - skipped
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Check for working CXX compiler: /usr/bin/g++ - skipped
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/workspace/prod-v1/bsr/105498/fceea/.conan/data/pole/0.5.4/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/build/Release
    pole/0.5.4: CMake command: cmake --build "/home/conan/workspace/prod-v1/bsr/105498/fceea/.conan/data/pole/0.5.4/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/build/Release" '--' '-j3'
    
    ----Running------
    > cmake --build "/home/conan/workspace/prod-v1/bsr/105498/fceea/.conan/data/pole/0.5.4/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/build/Release" '--' '-j3'
    -----------------
    Scanning dependencies of target pole
    [ 50%] Building CXX object CMakeFiles/pole.dir/pole/pole.o
    CMakeFiles/pole.dir/build.make:81: recipe for target 'CMakeFiles/pole.dir/pole/pole.o' failed
    CMakeFiles/Makefile2:94: recipe for target 'CMakeFiles/pole.dir/all' failed
    Makefile:148: recipe for target 'all' failed
    pole/0.5.4: 
    CMake Warning (dev) in CMakeLists.txt:
      No cmake_minimum_required command is present.  A line of code such as
    
        cmake_minimum_required(VERSION 3.18)
    
      should be added at the top of the file.  The version specified may be lower
      if you wish to support older CMake versions for this project.  For more
      information run "cmake --help-policy CMP0000".
    This warning is for project developers.  Use -Wno-dev to suppress it.
    
    /home/conan/workspace/prod-v1/bsr/105498/fceea/.conan/data/pole/0.5.4/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/src/pole/pole.cpp: In constructor ‘POLE::StorageIO::StorageIO(POLE::Storage*, const char*)’:
    /home/conan/workspace/prod-v1/bsr/105498/fceea/.conan/data/pole/0.5.4/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/src/pole/pole.cpp:1234:27: error: ‘uint64_t’ was not declared in this scope
         dirtree(new DirTree( (uint64_t) 1 << header->b_shift)),
                               ^
    make[2]: *** [CMakeFiles/pole.dir/pole/pole.o] Error 1
    make[1]: *** [CMakeFiles/pole.dir/all] Error 2
    make: *** [all] Error 2
    WARN: **************************************************
    WARN: *** Conan 1 is legacy and on a deprecation path **
    WARN: *********** Please upgrade to Conan 2 ************
    WARN: **************************************************
    pole/0.5.4: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    pole/0.5.4: ERROR: Package '4d887c1c2779c63d2cdd81580698d2e22cb35b29' build failed
    pole/0.5.4: WARN: Build folder /home/conan/workspace/prod-v1/bsr/105498/fceea/.conan/data/pole/0.5.4/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/build/Release
    ERROR: pole/0.5.4: Error in build() method, line 49
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build "/home/conan/workspace/prod-v1/bsr/105498/fceea/.conan/data/pole/0.5.4/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/build/Release" '--' '-j3'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@AbrilRBS AbrilRBS self-assigned this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants