-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[level-zero] added new recipe #25068
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
8153f72
to
37956b9
Compare
This comment has been minimized.
This comment has been minimized.
37956b9
to
a92f46b
Compare
This comment has been minimized.
This comment has been minimized.
a92f46b
to
016034e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
016034e
to
83d1fbc
Compare
This comment has been minimized.
This comment has been minimized.
83d1fbc
to
e5e71ac
Compare
This comment has been minimized.
This comment has been minimized.
e5e71ac
to
e6844f2
Compare
This comment has been minimized.
This comment has been minimized.
e6844f2
to
d746037
Compare
This comment has been minimized.
This comment has been minimized.
ddb5c44
to
e504721
Compare
This comment has been minimized.
This comment has been minimized.
e504721
to
87c79ad
Compare
This comment has been minimized.
This comment has been minimized.
87c79ad
to
0804808
Compare
This comment has been minimized.
This comment has been minimized.
0804808
to
6a22d6e
Compare
This comment has been minimized.
This comment has been minimized.
6a22d6e
to
d9ea346
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
8653e77
to
e1f50e0
Compare
@uilianries , Could you please re-run checks? |
@RaguzovaTatyana Hello! I just triggered it now. Thank you for pinging! |
This comment has been minimized.
This comment has been minimized.
recipes/level-zero/all/conanfile.py
Outdated
# Binary configuration | ||
settings = "os", "arch", "compiler", "build_type" | ||
options = { | ||
"shared": [True, False], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"shared": [True, False], |
You may remove shared option, otherwise, when using -o "/:shared=False" will fail due the InvalidConfiguration in this recipe. In case no having the shared option, it will be linked to the shared library always.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @uilianries, there's an error saying "Package type is 'library', but no 'shared' option declared", are you sure this option can be removed this case?
recipes/level-zero/all/conanfile.py
Outdated
settings = "os", "arch", "compiler", "build_type" | ||
options = { | ||
"shared": [True, False], | ||
"fPIC": [True, False] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"fPIC": [True, False] |
fpic could be removed as well as it only provides shared library.
e1f50e0
to
e2ddcaa
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e2ddcaa
to
501bfbd
Compare
This comment has been minimized.
This comment has been minimized.
501bfbd
to
43d494b
Compare
This comment has been minimized.
This comment has been minimized.
43d494b
to
c251baa
Compare
class LevelZeroConan(ConanFile): | ||
name = "level-zero" | ||
license = "MIT" | ||
homepage = "https://github.com/oneapi-src/level-zero" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this can only be built as a shared library (judging by https://github.com/oneapi-src/level-zero/blob/master/source/CMakeLists.txt#L14-L19) - then I think the package type needs to be set to shared-library
c251baa
to
ada0506
Compare
This comment has been minimized.
This comment has been minimized.
ada0506
to
0fe0dbe
Compare
This comment has been minimized.
This comment has been minimized.
0fe0dbe
to
a346410
Compare
Conan v1 pipeline ❌Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. Failure in build 31 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Summary
Changes to recipe: level-zero/1.17.28
Motivation
Openvino recipe needs level-zero to support execution on Intel NPU devices
this library also might be used by libfabric
Details