[luajit] Use Conan Center Backup Sources for sources #25061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
AbrilRBS
previously approved these changes
Aug 27, 2024
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit a72e915luajit/2.1.0-beta3@#e8ee964ad9fedb6ebd93b83ec3452a62 |
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline ✔️
All green in build 5 (
|
memsharded
approved these changes
Aug 29, 2024
AbrilRBS
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: luajit/2.1.0-beta3
Motivation
The issue #25032 brought a case where the upstream dropped the download of tags for tarball files, and recommended to use their rolling release approach instead.
After speaking to the Conan team, we considered doing separated moves, first, fixing the broken recipe to use the backup sources. The current state is not only affecting CCI, but also breaks those packages listed in the issue. So we decided to make available old releases in ConanCenterIndex for now.
In a future moment, we should discuss another move to deal with rolling releases in Lua-JIT.
fixes #25032
/cc @uyha
Details
Using backup sources is not something new in CCI. The same usage can be found in:
It does not changed sources, they are the backup from the original source that was available in the upstream, the checksum (SHA-256) is the exactly same
UPDATE:
The version 2.0.5 is not available under backup sources, only 2.1.0-beta3. So I removed it from the build. The package
libuclusesluajit/2.0.5as optional requirement, not enabled by default, so it should not break CCI.