Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws refactor] aws-sdk-cpp: Review dependencies, add new version and remove old one #24924

Merged
merged 40 commits into from
Sep 24, 2024

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Aug 13, 2024

Related to #24831

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Aug 20, 2024
@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

I just tried to build this PR for Android and it failed in the configure:
aws-sdk-cpp-1.11.352-android.log

However, is better than in master branch. When trying to build the master branch, not even aws-c-common/0.6.11 does not build.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added Failed Version conflict There is a version conflict when solving the dependencies graph labels Sep 23, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed Failed Version conflict There is a version conflict when solving the dependencies graph labels Sep 24, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 38 (b34f0ff5cff357cde84c245d81e8b8c1618327e8):

  • aws-sdk-cpp/1.9.234:
    Built 17 packages out of 22 (All logs)

  • aws-sdk-cpp/1.11.352:
    Built 17 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 37 (b34f0ff5cff357cde84c245d81e8b8c1618327e8):

  • aws-sdk-cpp/1.11.352:
    Built 6 packages out of 10 (All logs)

  • aws-sdk-cpp/1.9.234:
    Built 6 packages out of 10 (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@conan-center-bot conan-center-bot merged commit 696d196 into conan-io:master Sep 24, 2024
13 checks passed
@maksim-petukhov
Copy link
Contributor

@AbrilRBS @uilianries @danimtb this PR breaks Windows builds by unconditionally requiring s2n package. All Windows builds report INVALID_CONFIGURATION now.

@danimtb
Copy link
Member Author

danimtb commented Sep 25, 2024

@maksim-petukhov we are looking at it, thanks for your quick report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants