Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add zstd and ninja to version ranges supported #24723

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

uilianries
Copy link
Member

Motivation

Both zstd and ninja looks pretty stable and should be backward compatible to be used in ConanCenterIndex.

Details


Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries requested a review from jcar87 July 26, 2024 11:18
@uilianries uilianries self-assigned this Jul 26, 2024
jcar87
jcar87 previously approved these changes Jul 26, 2024
AbrilRBS
AbrilRBS previously approved these changes Jul 29, 2024
@uilianries uilianries dismissed stale reviews from AbrilRBS and jcar87 via ddb60a6 July 29, 2024 09:38
@uilianries
Copy link
Member Author

I just included Meson too. It looks stable so far. The version 1.2.x is well used in CCI and is 1 year old.

AbrilRBS
AbrilRBS previously approved these changes Jul 29, 2024
@valgur
Copy link
Contributor

valgur commented Jul 29, 2024

Maybe add pkgconf/[>=2.2 <3] to the list as well, based on be88746#diff-c548829da9d38ae15a8cb4447140bc50ac3f38250d1f348decd9569dc3298b24R405 ?

@conan-center-bot conan-center-bot merged commit 4c3aba0 into conan-io:master Jul 30, 2024
9 checks passed
@@ -192,6 +196,10 @@ version range only when a requirement for a newer version is needed.
* qt5: `[~5.15]`, if your library depends on qt5, only the 5.15 minor version is allowed
* qt6: `[>=6.x <7]`, where 6.x is the lower bound of your needed qt6 version
* c-ares: `[>=1.27 <2]`
* zstd: `[^1.5]` it's equivalent to `[>=1.5 <1.6]`
Copy link
Contributor

@SpaceIm SpaceIm Aug 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, [^1.5] is equivalent to [>=1.5 <2]. Do you want [~1.5]?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. https://docs.conan.io/1/versioning/version_ranges.html#version-ranges I'll open a PR fixing it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants