-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emsdk: add new version 3.1.68 #24218
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Minor change, otherwise looks good!
These are the failing configurations: https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/24218/1-macos-m1-clang/emsdk/2.0.34//summary.json |
@RubenRBS |
Let me know if you need any help from my side! |
This comment has been minimized.
This comment has been minimized.
Umm, strange. @RubenRBS emsdk/3.1.6 build on macOSX apple-clang 15.0.0======== Exporting recipe to the cache ======== ======== Input profiles ======== Profile build: ======== Computing dependency graph ======== ======== Computing necessary packages ======== ======== Installing packages ======== -------- Installing package emsdk/3.1.61 (2 of 2) -------- emsdk/3.1.61: RUN: ./emsdk activate releases-upstream-28e4a74b579b4157bda5fc34f23c7d3905a8bd6c-64bit Next steps:
emsdk/3.1.61: Package 'dcf68e932572755309a5f69f3cee1bede410e907' built emsdk/3.1.61: package(): Packaged 68 '.txt' files ======== Launching test_package ======== ======== Computing dependency graph ======== ======== Computing necessary packages ======== ======== Installing packages ======== ======== Testing the package ======== ======== Testing the package: Building ======== ======== Testing the package: Executing test ======== emsdk/3.1.61 (test package): RUN: em++ -v |
LGTM, you may have to also bump Node to 18.20.3 though. That's the LTS that currently ships via emsdk latest. 18.15.0 would ship with Conan and is probably good enough. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -29,17 +31,29 @@ def layout(self): | |||
basic_layout(self, src_folder="src") | |||
|
|||
def requirements(self): | |||
self.requires("nodejs/16.3.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There has been some talk about this recipe requiring nodejs directly, instead of it being a tool_requires, we should clarify if it's really needed or if we could get away with tool_requireing it.
The issue is that users of emsdk are not able to override nodejs, and they get conflicts using it as a tool_requires
Conan v1 pipeline ❌Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. Failure in build 7 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Specify library name and version: emsdk/3.1.68
emscripten-core/emsdk@3.1.50...3.1.68