Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thrift: add v0.20.0 and bump deps #24046

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

robomics
Copy link
Contributor

Specify library name and version: thrift/all


@robomics robomics changed the title thrift: add thrift v0.20.0 and bump deps thrift: add v0.20.0 and bump deps May 20, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (f971ff887c163782984956e7efcb58d69f90cb5b):

  • thrift/0.18.1:
    All packages built successfully! (All logs)

  • thrift/0.15.0:
    All packages built successfully! (All logs)

  • thrift/0.14.2:
    All packages built successfully! (All logs)

  • thrift/0.17.0:
    All packages built successfully! (All logs)

  • thrift/0.20.0:
    All packages built successfully! (All logs)

  • thrift/0.16.0:
    All packages built successfully! (All logs)

  • thrift/0.14.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (f971ff887c163782984956e7efcb58d69f90cb5b):

  • thrift/0.14.2:
    All packages built successfully! (All logs)

  • thrift/0.14.1:
    All packages built successfully! (All logs)

  • thrift/0.17.0:
    All packages built successfully! (All logs)

  • thrift/0.20.0:
    All packages built successfully! (All logs)

  • thrift/0.16.0:
    All packages built successfully! (All logs)

  • thrift/0.15.0:
    All packages built successfully! (All logs)

  • thrift/0.18.1:
    All packages built successfully! (All logs)

@franramirez688 franramirez688 self-assigned this Jun 5, 2024
@conan-center-bot conan-center-bot merged commit f8a8a29 into conan-io:master Jun 5, 2024
44 checks passed
@CJCombrink
Copy link
Contributor

@robomics Thanks for the effort, you saved me from doing it :D

@CJCombrink
Copy link
Contributor

@franramirez688 Thanks for the approval and merge

@robomics robomics deleted the bump/thrift branch June 5, 2024 09:17
@jcar87
Copy link
Contributor

jcar87 commented Jun 14, 2024

pleaase be aware that version bumping like this introduces a conflict in opentelemetry-cpp.

I would advise against bumping versions unnecessarily unless there is a clear reason - for example, a new feature in boost that is required.

@CJCombrink
Copy link
Contributor

CJCombrink commented Jun 14, 2024

@jcar87 I am very curious why adding a new thrift version have an affect on another package?
personally I think the packages should be independent of each other, except perhaps those that use ranges that the conan peaple have deemed can be ranged, like zlib and openssl when I last looked....

clear reason

0.20 is newer than 0.18.1, should be reason enough for a package manager

ps: thrift is pinned in opentelemetry-cpp, that am I missing?

self.requires("thrift/0.17.0")

Edit/update: probably the fact that opentelemetry-cpp specifies self.requires("boost/1.84.0"), perhaps it should get an override

self.requires("boost/1.84.0", override)

@CJCombrink
Copy link
Contributor

I quickly looked at opentelemetry-cpp and it seems like it does not require boost, thrift requires boost. So perhaps the correct thing is to remove boost from the opentelemetry-cpp recipe?

(I am not familiar with opentelemetry-cpp)

@CJCombrink
Copy link
Contributor

CJCombrink commented Jun 14, 2024

Ok finally it also seems that opentelemetry-cpp dropped the thrift requirement in version [1.10.0] 2023-07-11

[REMOVAL] Remove the jaeger exporter open-telemetry/opentelemetry-cpp#2031

So no need to worry about breaking it from the thrift side any more I guess.

Thus I stand on opentelemetry-cpp recipe must either get override on boost version or not specify it and use what thrift uses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants