-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thrift: add v0.20.0 and bump deps #24046
Conversation
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
@robomics Thanks for the effort, you saved me from doing it :D |
@franramirez688 Thanks for the approval and merge |
pleaase be aware that version bumping like this introduces a conflict in opentelemetry-cpp. I would advise against bumping versions unnecessarily unless there is a clear reason - for example, a new feature in boost that is required. |
@jcar87 I am very curious why adding a new thrift version have an affect on another package?
0.20 is newer than 0.18.1, should be reason enough for a package manager ps: thrift is pinned in opentelemetry-cpp, that am I missing?
Edit/update: probably the fact that opentelemetry-cpp specifies
|
I quickly looked at opentelemetry-cpp and it seems like it does not require boost, thrift requires boost. So perhaps the correct thing is to remove boost from the opentelemetry-cpp recipe? (I am not familiar with opentelemetry-cpp) |
Ok finally it also seems that opentelemetry-cpp dropped the thrift requirement in version [1.10.0] 2023-07-11
So no need to worry about breaking it from the thrift side any more I guess. Thus I stand on opentelemetry-cpp recipe must either get override on boost version or not specify it and use what thrift uses |
Specify library name and version: thrift/all