-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arrow: fix recipe when arrow/*:parquet=True #24044
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
Thanks! Please also set |
Another thing I noticed, is that arrow always uses a vendored version of mimalloc: https://github.com/apache/arrow/blob/b2e8c33c86c819b167a1cbca834da3c9047a9350/cpp/cmake_modules/ThirdpartyToolchain.cmake#L2197-L2204 Should I drop mimalloc from the requirement list (but leave the option to toggle mimalloc on or off)? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@RubenRBS I think this is ready for review :). The conan v2 pipeline failure seems to be due to the same issue described in #24011. |
This comment has been minimized.
This comment has been minimized.
uhm... It looks like the |
This comment has been minimized.
This comment has been minimized.
@robomics building missing binaries now... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@perseoGI I am bumping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 23 (
Conan v2 pipeline ✔️
All green in build 25 (
|
@perseoGI CI is green! :) |
Specify library name and version: arrow/all
When the arrow package is built with
arrow/*:parquet=True
,arrow/*:with_thrift=True
is also required.Thrift is found by Arrow by calling FindThriftAlt.cmake, which uses some custom logic to define
thrift::thrift
when the project is compiled on Windows.This causes the
transitive_header=True
specified in Thrift's recipe to be ignored.conan-center-index/recipes/thrift/all/conanfile.py
Lines 69 to 70 in b4b8a8d
This PR patches FindThriftAlt.cmake so that
find_package(Thrift)
is always called.Fixes #20082 (note that without the patch I am unable to build the package using MSVC regardless of the
build_type
).While debugging the above issue I also realized that
ARROW_WITH_RE2
was not explicitly set by the recipe, which on my machine causes compilation to fail for v11.0.0. This PR also addresses this issue.Finally, I am bumping
thrift
,xsimd
, andzstd
to avoid version conflicts with other packages on cci.