-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update range list to add libpng (And mention libxml) #23016
Update range list to add libpng (And mention libxml) #23016
Conversation
🤖 Beep Boop! This pull request is making changes to 'docs//'. 👋 @prince-chrismc @MartinDelille @Croydon you might be interested. 😉 |
docs/adding_packages/dependencies.md
Outdated
> We're adding them little by little to avoid missing binaries and conflict errors. | ||
> Please do not open PRs moving Zlib to ranges for now, we'll update this page when PRs are free to add new ranges. | ||
> Please do not open PRs moving Libpng to ranges for now, we'll update this page when PRs are free to add new ranges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd mention to please not open PRs where the only change is adding a version range to a requirement, unless the PR is solving a conflict (in which case the PR is very much welcome and will be prioritised).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Let's do it explicit, otherwise we may have new PRs only changing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After consideration, we'll allow libpng to the range list
As for the libxml dependency, we're also open to it being added, but still need to do some more research