Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libselinux: Fix cross-compilation #22952

Merged

Conversation

jwillikers
Copy link
Contributor

@jwillikers jwillikers commented Mar 1, 2024

Apply patches for 3.6 to fix detection of available functions when cross-compiling. Use the PKG_CONFIG_LIBDIR to point pkg-config to the correct directory containing Conan's generated pkg-config files. Without this, the pcre2 from the system will be picked up before the one provided by Conan. When cross-compiling, this causes system include directories to poison the build.

libselinux-3.6-cross-fixed-log.txt
libselinux-3.6-cross-broken-log.txt

@conan-center-bot

This comment has been minimized.

Apply patches for 3.6 to fix detection of available functions when cross-compiling.
Use the PKG_CONFIG_LIBDIR to point pkg-config to the correct directory containing Conan's generated pkg-config files.
Without this, the pcre2 from the system will be picked up before the one provided by Conan.
When cross-compiling, this causes system include directories to poison the build.
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jwillikers Thanks a lot for this PR (and the associated issue 😁 )

Sorry for the huge delay! I'm just revisiting all my old assigned issues! 🙏

LGTM! I only have a question regarding to the environment.

recipes/libselinux/all/conanfile.py Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (785e1fa6a12e4a4e666555b07f5a7f7caee3c0ec):

  • libselinux/3.6:
    All packages built successfully! (All logs)

  • libselinux/3.5:
    All packages built successfully! (All logs)

  • libselinux/3.1:
    All packages built successfully! (All logs)

  • libselinux/3.3:
    All packages built successfully! (All logs)

  • libselinux/3.2:
    All packages built successfully! (All logs)

  • libselinux/3.0:
    All packages built successfully! (All logs)

  • libselinux/2.9:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (785e1fa6a12e4a4e666555b07f5a7f7caee3c0ec):

  • libselinux/3.6:
    All packages built successfully! (All logs)

  • libselinux/3.5:
    All packages built successfully! (All logs)

  • libselinux/3.2:
    All packages built successfully! (All logs)

  • libselinux/3.3:
    All packages built successfully! (All logs)

  • libselinux/3.1:
    All packages built successfully! (All logs)

  • libselinux/3.0:
    All packages built successfully! (All logs)

  • libselinux/2.9:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 371cd5b into conan-io:master Jun 6, 2024
43 checks passed
@jwillikers jwillikers deleted the libselinux-cross-compile branch June 6, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants