-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost: add version 1.84.0 #21747
boost: add version 1.84.0 #21747
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/boost//'. 👋 @grafikrobot @Hopobcn @jwillikers you might be interested. 😉 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
What about this change?
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The Conan 2.x build is finished and the current error is related to a boost component:
|
I'll investigate that error related to fiber on Windows. Excluding windows:shared=True is too much. |
opened an issue to Boost fiber reporting the error: boostorg/fiber#314 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Hope this can be merged soon.
Could this merged soon? Thx!!! |
What's the blocker here? Any reason why this could not be merged? @uilianries? |
Is this issue the blocker? boostorg/fiber#314 |
Upstream bugs should never block a package release. I'm also wondering on the delay for this. |
Right now, this PR is not generating any package for Windows, due fiber error. I would recommend switching fiber to disable in 1.84, then it would generate everything "normally". Once we have it fixed, we can push an official patch and bring back fiber as enabled. |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 35806e2boost/1.82.0@#9a2a27d3f97f4d3e9202804115216cc5
boost/1.74.0@#46e0687706ffac15d72334044b478570
boost/1.84.0@#afccc1a767c213f453f52622eaf4c5d9
boost/1.83.0@#2b2a1a612d12b48a833d7283d59d4036
boost/1.80.0@#841d071dee4747fc03466b175542baf7
boost/1.81.0@#ab70ad81c04f9abb01b63b7abad46bb6
boost/1.73.0@#9a55026800a2ac661350518bf104a7f1
boost/1.79.0@#666beef85e3f1628bcb6125c8eff1da2
boost/1.78.0@#ec7a11f2c4ef04aa3e0383024988ee37
boost/1.77.0@#b031d4e9aa40fdf0e0087cd819270fc5
boost/1.76.0@#8f24fe4da3145ed4407aed057636cb5d
boost/1.72.0@#541901bbf86836844e6199b82de38fef
boost/1.71.0@#a1a7da522a0cacec7739436ad22bfc73
boost/1.75.0@#a838ce686cbbbc4e206632d52e56001e
|
Thanks for the explanation. We have |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Hooks produced the following warnings for commit 7024790boost/1.84.0@#deb1d5554dc6ef62ad76b4d113575947
boost/1.82.0@#7053477b271b8c39e046f784405b402f
boost/1.83.0@#39551a6ba03b4fe2c7a86b9a6d80cd67
boost/1.81.0@#75fa1ca9f522d084e03177c6fc908bbd
boost/1.76.0@#df39c532f70f7cb5ff9f193e00efa4eb
boost/1.74.0@#4768337d9911c3a8f0eae1f5cac19a7e
boost/1.71.0@#14b73fe362720d6d7491d88484438f38
boost/1.78.0@#a20617a8ac88629da4ceacb481694192
boost/1.77.0@#f73a028ab9d8e5bbf68207ee18391fa8
boost/1.79.0@#d8a5b9e748e4152d6f489d7d87a1f129
boost/1.75.0@#ae3f1f09b2bfddbbf849f4eed9d2c6d6
boost/1.72.0@#9e0f04477ea01d13b31edd51069bd010
boost/1.73.0@#1c18ca532ae54c2c41f51812baa381c3
boost/1.80.0@#99c19b28b741645c7056014aee69ebd0
|
Any updates on the merge? |
This PR has some limitations with Conan 1.x, we will a second PR to fix it. For now, no packages with Boost 1.84.0 with MacOS and GCC5 are being generated with Conan 1.x. The missing cppstd in the profile is causing it. GCC5 supports C++11 and uses it by default (https://gcc.gnu.org/gcc-5/changes.html), second, Apple Clang supports C++11 and later, but it uses 98 by default. We will need to adjust it, to use C++11 when not defined cppstd. |
if self.settings.compiler == "apple-clang": | ||
# For now, assume apple-clang will enable c++11 in the distant future | ||
return 99 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it removed? apple-clang 14 & 15 default C++ standard is still C++98.
Specify library name and version: boost/1.84.0
boost/1.84.0 added Cobalt and Redis libraires.
Cobalt is a static/shared library.
Redis is a header only library.
In boost/1.84.0, there are compilation errors on msvc shared build for boost.fiber.