Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cn-cbor: remove invalid check_min_cppstd #19618

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Sep 6, 2023

Required by the latest version of cose-c.

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AbrilRBS commented Sep 7, 2023

Maybe we can get upstream to generate a release we can pin?
In their READMe they have Conan instructions to use ranges and it would be a pitty if someone followed that and got an old commit

@AbrilRBS AbrilRBS self-assigned this Sep 7, 2023
@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@valgur
Copy link
Contributor Author

valgur commented Nov 29, 2023

Maybe we can get upstream to generate a release we can pin? In their READMe they have Conan instructions to use ranges and it would be a pitty if someone followed that and got an old commit

@RubenRBS That would be ideal, indeed, but I don't really feel like taking that on currently, tbh. Can we merge this one as is, maybe?

Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project has had no activity for 4 years, so I think it's not worth adding the last commit as a new version. If they release a new version, let's add it for sure.

recipes/cn-cbor/all/conandata.yml Outdated Show resolved Hide resolved
recipes/cn-cbor/config.yml Outdated Show resolved Hide resolved
@franramirez688 franramirez688 changed the title cn-cbor: add version cci.20200822, remove invalid check_min_cppstd cn-cbor: remove invalid check_min_cppstd Mar 7, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (198838ebeb7143ee7ab098d6640412b69f395566):

  • cn-cbor/1.0.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (198838ebeb7143ee7ab098d6640412b69f395566):

  • cn-cbor/1.0.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit f885060 into conan-io:master Mar 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants