Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsgxchange recipe #18421

Closed
wants to merge 9 commits into from
Closed

vsgxchange recipe #18421

wants to merge 9 commits into from

Conversation

psyinf
Copy link
Contributor

@psyinf psyinf commented Jul 8, 2023

vsgxchange/1.0.2

First addition to the VulkanSceneGraph (vsg) zoo of additional libraries

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@stale stale bot removed the stale label Sep 30, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (f76370deb4c5afa4c0b28ad38056dad3e7faf624):

  • vsgxchange/1.0.2:
    All packages built successfully! (All logs)

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 7 (f76370deb4c5afa4c0b28ad38056dad3e7faf624):

  • vsgxchange/1.0.2:
    CI failed to create some packages (All logs)

    Logs for packageID 0561973cf07bf2ed21bc208fbad0250391001c9e:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=True
    
    [...]
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `X509_NAME_get_index_by_NID@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `X509_get0_notBefore@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `PEM_write_bio_X509@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `BIO_set_init@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `BN_num_bits@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `X509_EXTENSION_get_data@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `X509V3_EXT_print@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `EVP_PKEY_get0_DH@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `SSL_alert_desc_string_long@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `SSL_CTX_set_default_passwd_cb_userdata@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `DSA_get0_key@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `ERR_error_string_n@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `CRYPTO_free@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `UI_OpenSSL@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `RAND_bytes@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `EVP_PKEY_free@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `MD5_Final@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `ENGINE_get_id@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `SSL_connect@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `OCSP_cert_status_str@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `DES_set_key_unchecked@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `X509_get0_notAfter@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `X509_verify_cert_error_string@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `SSL_new@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `OPENSSL_sk_pop@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `SSL_CTX_set_alpn_protos@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `SSL_CTX_use_certificate_file@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `OPENSSL_sk_num@OPENSSL_1_1_0'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/15450/cacee/p/libcu73c29c75b52fb/p/lib/libcurl.so.4: undefined reference to `BIO_free@OPENSSL_1_1_0'
    collect2: error: ld returned 1 exit status
    applications/vsgconv/CMakeFiles/vsgconv.dir/build.make:86: recipe for target 'bin/vsgconv' failed
    make[2]: *** [bin/vsgconv] Error 1
    CMakeFiles/Makefile2:228: recipe for target 'applications/vsgconv/CMakeFiles/vsgconv.dir/all' failed
    make[1]: *** [applications/vsgconv/CMakeFiles/vsgconv.dir/all] Error 2
    Makefile:129: recipe for target 'all' failed
    make: *** [all] Error 2
    
    vsgxchange/1.0.2: ERROR: 
    Package '0561973cf07bf2ed21bc208fbad0250391001c9e' build failed
    vsgxchange/1.0.2: WARN: Build folder /home/conan/w/prod-v2/bsr/15450/cacee/p/b/vsgxc41ce0d418b8cd/b
    *********************************************************
    Recipe 'vsgxchange/1.0.2' cannot build its binary
    It is possible that this recipe is not Conan 2.0 ready
    If the recipe comes from ConanCenter check: https://conan.io/cci-v2.html
    If it is your recipe, check if it is updated to 2.0
    *********************************************************
    
    ERROR: vsgxchange/1.0.2: Error in build() method, line 96
    	cmake.build()
    	ConanException: Error 2 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@psyinf
Copy link
Contributor Author

psyinf commented Oct 16, 2023

@conan-io/barbarians I'm not quite sure why the conan v2.0 pipeline fails with the libcurl here. Any hints?

Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MSVC runtime handling could use more info, otherwise LGTM.

self.requires("vsg/1.0.3")
#optional
if self.options.with_curl:
self.requires("libcurl/8.0.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.requires("libcurl/8.0.0")
self.requires("libcurl/[>=7.78.0 <9]")

)

def source(self):
get(self, **self.conan_data["sources"][self.version], strip_root=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
get(self, **self.conan_data["sources"][self.version], strip_root=True)
get(self, **self.conan_data["sources"][self.version], strip_root=True)

Comment on lines +82 to +83
if is_msvc(self):
tc.variables["USE_MSVC_RUNTIME_LIBRARY_DLL"] = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 24, 2024
Copy link
Contributor

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@github-actions github-actions bot closed this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants