- add GCC 10.1.0 #1694

SSE4 · 2020-05-21T14:02:12Z

Specify library name and version: gcc/10.1.0

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

Signed-off-by: SSE4 <tomskside@gmail.com>

uilianries · 2020-05-21T17:43:05Z

This is a interesting package, but what's the propose, general usage or integrate with CCI?

SSE4 · 2020-05-21T17:47:11Z

@uilianries several goals:

use as build requires to install GCC (potentially cross-compiler, but also useful on Mac and other systems) within conan profile
some real, complex use-case to test cross-building feature (eventually, first iteration doesn't support cross-building), e.g. be able to cross-compile a cross-compiler as an ultimate goal

Croydon · 2020-05-21T18:23:32Z

Cross-compiling a cross-compiler?

Now my brain hurts

uilianries · 2020-05-21T18:31:01Z

Cross-compiling a cross-compiler?

Now my brain hurts

Recursive building?

madebr

Great recipe @SSE4 !!

Doesn't this recipe require (a minimum version of) binutils?
binutils contains ar, ld, ld.gold and as.
These are programs that are essential for assembling and linking.

madebr · 2020-05-21T18:32:09Z

recipes/gcc/all/conanfile.py

+        cc = os.path.join(bindir, "gcc-%s" % self.version)
+        self.output.info("Creating CC env var with : " + cc)
+        self.env_info.CC = cc
+
+        cxx = os.path.join(bindir, "g++-%s" % self.version)
+        self.output.info("Creating CXX env var with : " + cxx)
+        self.env_info.CXX = cxx


Do we want to set CC and CXX here?
Isn't that the role of the profile?

I assume that they are needed here, if you are using this recipe as a build_requires then you expect it to populate the environment so it is actually used...

Yes in this case, as you require this specific package, you have to use this compiler. Using a CC and CXX from profile, pointing to another compiler, creates an impredecible behavior

is there a way to set CC within the profile relative to the build requires?
something like:

[build_requires] gcc/10.1.0@ [env] CC=os.path.join(self.deps_cpp_info["gcc"].root_path, "bin", "gcc") CXX=os.path.join(self.deps_cpp_info["gcc"].root_path, "bin", "g++")

I doubt it's possible right now, so I worry there is no way to achieve the same result without env_info

Nope, but it's a relevant feature.

@SSE4
I think this is now possible with using conan 1.38.0, jusing python code in profiles.

@uilianries
What does it mean now, should users of this package put it in a profile or as a build_require step in a conan recipe?

jgsogo · 2020-05-21T18:38:42Z

\o/

...but we are not going to use it for CCI, we don't want this recipe to be a build_requires of every recipe 😅

but yes, I would love to try the cross-building feature with this recipe, this will be really helpful

uilianries · 2020-05-21T18:45:50Z

@SSE4 Did you check the package size? I guess it will require ~1GB.

Croydon · 2020-05-21T20:27:43Z

recipes/gcc/all/conanfile.py

+    topics = ("gcc", "gnu", "compiler", "c", "c++")
+    homepage = "https://gcc.gnu.org/"
+    url = "https://github.com/conan-io/conan-center-index"
+    license = "	GPL-3.0-only"


I have seen this a lot: spaces in front of the license ID. How is this happening? Is this a copy&paste thing from the SPDX list which contains somehow spaces or something similar?

this is mostly human error, I've just copy-pasted from the SPDX web-site

uilianries · 2020-05-21T20:59:49Z

recipes/gcc/all/conanfile.py

+
+    def package(self):
+        autotools = self._configure_autotools()
+        autotools.install(args=self._make_args)


I would run install-strip instead: https://github.com/docker-library/gcc/blob/master/Dockerfile.template#L125

As you can see, the official GCC docker image uses it. The idea is strip the binaries, so the package size will be much smaller.

okay, let's add this as well

jgsogo · 2020-05-22T08:38:44Z

@uilianries

@SSE4 Did you check the package size? I guess it will require ~1GB.

Not so big. According to Artifactory (the conan_package.tgz file) it is 301.49 MB for the Debug build and 94.25 MB for the Release build.

SSE4 · 2020-05-22T09:07:30Z

@madebr binutils will be for sure needed for the cross-building use-case. for the regular build, you already have right binutils, so for the first step, it's not a strong requirement.

SSE4 · 2020-05-22T09:08:09Z

@jgsogo yes, definitely, it's not going to be used as a build_requires in CCI recipes, that's not an intention right now.

madebr · 2020-05-22T12:02:39Z

@madebr binutils will be for sure needed for the cross-building use-case. for the regular build, you already have right binutils, so for the first step, it's not a strong requirement.

Indeed, native binutils will be available when you build the gcc package yourself, but it won't be if you downloaded the package from bintray on a fresh linux installation.
Same goes for glibc.

SSE4 · 2020-05-25T14:11:25Z

@madebr I guess you're right, if install on very empty linux, e.g. embedded system, it will probably fail to run due to the missing glibc and bintuils. I'll create binutils recipe as well, probably once this one is merged, as it's the next step for the cross-building. right now, it's a bit out of scope of the initial recipe version, since we can assume for the majority of non-cross-compiled cases that binutils are already there.

stale · 2022-01-03T00:23:34Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

stale · 2022-02-21T04:02:28Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

derived-coder · 2022-03-27T12:18:50Z

recipes/gcc/all/conanfile.py

+    homepage = "https://gcc.gnu.org"
+    url = "https://github.com/conan-io/conan-center-index"
+    license = "GPL-3.0-only"
+    settings = "os", "compiler", "arch", "build_type"


Why not just:
settings = "os", "arch"
?

We follow this recommendation: https://github.com/conan-io/conan-center-index/blob/master/docs/packaging_policy.md#settings, sometimes it is useful to know self.settings.compiler inside the recipe, so better to keep the setting and remove it from packageID.

stale · 2022-04-27T09:01:56Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Croydon · 2022-04-27T13:30:06Z

Some of the latest comments were that it would be good to have a binutils recipe first. We have that now.

How can we move this forward?

uilianries · 2022-04-27T14:25:49Z

I think it just need binutils update. 🤔

madebr · 2022-04-27T14:57:08Z

I still don't think this recipe is correct.
A toolchain consists of:

binutils for the assembler/linker/various tools.
a library targeting an operating system (most commonly glibc on Linux)
a compiler, in this case gcc

If we truly want to create a gcc recipe that can be used as a build requirement without needing any file on the build system,
we need all of the above.
All downloadable toolchains on the interwebs have all 3 things above combined.
So I think we need to have a single recipe that combines binutils/gcc/glibc.
That recipe would only be able to target Linux.
For Windows, we'ld need to add mingw-w64 into the mix.

See the mingw-w64/linux recipe on how it consists of binutils + gmp + mpfr + mingw-w64 + gcc.

conan-center-bot · 2022-05-03T08:32:01Z

All green in build 6 (8069f33340a48a3d044c7a396bc02ec4862c03e1):

gcc/10.2.0@:
All packages built successfully! (All logs)

jgsogo

IMHO we can move this recipe forward, it can be a starting point to improve it. We know there are some really hard recipes that are not perfect, and they might suffer breaking (really breaking) changes in the future (recipe revisions to the rescue!). But I think it is better to start having something and work on top of it.

More people will start to contribute to the effort if they see there is something already available.

uilianries · 2022-05-19T10:48:30Z

I'm a Linux user (BTW I use Arch), if it builds on Linux, it's work for me and we can improve later, as Javier said

- add GCC 10.1.0

b5b3b90

Signed-off-by: SSE4 <tomskside@gmail.com>

SSE4 requested review from jgsogo, uilianries and danimtb May 21, 2020 14:02

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label May 21, 2020

Update conanfile.py

eb2e24e

This comment has been minimized.

Sign in to view

Update conanfile.py

754165e

This comment has been minimized.

Sign in to view

Update conanfile.py

551b862

This comment has been minimized.

Sign in to view

conan-center-bot removed the Failed label May 21, 2020

madebr reviewed May 21, 2020

View reviewed changes

Croydon reviewed May 21, 2020

View reviewed changes

gcc: remove unnecessary spaces

a91b3f1

uilianries reviewed May 21, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

Update conanfile.py

fb9d8e9

stale bot added the stale label Dec 3, 2021

stale bot closed this Jan 3, 2022

SSE4 reopened this Jan 21, 2022

stale bot removed the stale label Jan 21, 2022

This comment has been minimized.

Sign in to view

stale bot added the stale label Feb 21, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Unexpected Error label Mar 10, 2022

stale bot removed the stale label Mar 10, 2022

This comment has been minimized.

Sign in to view

conan-center-bot removed the Unexpected Error label Mar 13, 2022

derived-coder reviewed Mar 27, 2022

View reviewed changes

stale bot added the stale label Apr 27, 2022

stale bot removed the stale label Apr 27, 2022

SSE4 closed this Apr 30, 2022

SSE4 reopened this Apr 30, 2022

This comment has been minimized.

Sign in to view

jgsogo reviewed May 19, 2022

View reviewed changes

madebr approved these changes May 19, 2022

View reviewed changes

danimtb approved these changes May 19, 2022

View reviewed changes

conan-center-bot merged commit d8f83f6 into conan-io:master May 19, 2022

samuel-emrys mentioned this pull request Nov 13, 2022

[request] glibc/2.36 #14168

Open

- add GCC 10.1.0 #1694

- add GCC 10.1.0 #1694

Conversation

SSE4 commented May 21, 2020 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries commented May 21, 2020

SSE4 commented May 21, 2020

Croydon commented May 21, 2020

uilianries commented May 21, 2020 • edited Loading

madebr left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derived-coder Aug 5, 2021 • edited Loading

Choose a reason for hiding this comment

jgsogo commented May 21, 2020

uilianries commented May 21, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

jgsogo commented May 22, 2020

SSE4 commented May 22, 2020

SSE4 commented May 22, 2020

madebr commented May 22, 2020

SSE4 commented May 25, 2020

stale bot commented Jan 3, 2022

This comment has been minimized.

stale bot commented Feb 21, 2022

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Apr 27, 2022

Croydon commented Apr 27, 2022

uilianries commented Apr 27, 2022

madebr commented Apr 27, 2022 • edited Loading

This comment has been minimized.

conan-center-bot commented May 3, 2022

jgsogo left a comment

Choose a reason for hiding this comment

uilianries commented May 19, 2022

SSE4 commented May 21, 2020 •

edited

Loading

uilianries commented May 21, 2020 •

edited

Loading

madebr left a comment •

edited

Loading

derived-coder Aug 5, 2021 •

edited

Loading

madebr commented Apr 27, 2022 •

edited

Loading