qt: fix building on macos with llvm-clang #16313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉 |
ericLemanissier
previously approved these changes
Feb 27, 2023
ghost
mentioned this pull request
|
I detected other pull requests that are modifying qt/6.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
MartinDelille
previously approved these changes
Feb 27, 2023
This comment has been minimized.
This comment has been minimized.
How did it pass before? 🤔 |
This comment has been minimized.
This comment has been minimized.
ghost
mentioned this pull request
3 tasks
jwillikers
previously approved these changes
Mar 10, 2023
@hellozee The CMake package must have been updated and is causing the conflict. You'll have to bump the required |
hellozee
dismissed stale reviews from jwillikers, MartinDelille, and ericLemanissier
via
0afa3f5
jwillikers
previously approved these changes
Mar 10, 2023
MartinDelille
previously approved these changes
Mar 12, 2023
This was referenced Mar 16, 2023
Closed
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ericLemanissier
approved these changes
Apr 26, 2023
This comment has been minimized.
This comment has been minimized.
jwillikers
approved these changes
Apr 26, 2023
ghost
mentioned this pull request
3 tasks
This was referenced May 12, 2023
|
|
Conan v1 pipeline ✔️All green in build 6 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 5 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hooks produced the following warnings for commit 6c6605aqt/6.4.2qt/6.3.2qt/6.4.1qt/6.5.0qt/6.2.4 |
This was referenced Jun 13, 2023
Merged
This was referenced Jul 5, 2023
This was referenced Jul 18, 2023
Merged
Merged
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: qt/6.x.x
Qt manually adds some flags on macos but those are not applicable while building with llvm-clang. The patch got positive response from upstream
but yet to be mergedand is merged.Another approach could be using find and replace, but using a patch seemed straight forward.