Boost: use versionless soname on Android #16114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Beep Boop! This pull request is making changes to 'recipes/boost//'. 👋 @Hopobcn @jwillikers you might be interested. 😉 |
ghost
mentioned this pull request
|
I detected other pull requests that are modifying boost/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 7d1b991boost/1.79.0boost/1.77.0boost/1.81.0boost/1.78.0boost/1.71.0boost/1.75.0boost/1.74.0boost/1.73.0boost/1.76.0boost/1.70.0boost/1.80.0boost/1.72.0 |
ghost
mentioned this pull request
3 tasks
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Bump |
|
@grafikrobot can you comment on this one? |
@grafikrobot has approved the upstream PR shortly after I've posted there :) |
And I also just poked relevant people in slack about it. |
Please make this a patch file with the conandata yaml having a patch source pointing to the accept PR and it will be a super fast green tick :) |
patch file already exists https://patch-diff.githubusercontent.com/raw/boostorg/boost/pull/206.patch |
Initially I wanted to use the patch approach, but a single patch for all boost versions wouldn't work with Conan because it requires strict line match in the patch (unlike the
? |
grafikrobot
previously approved these changes
Apr 4, 2023
|
That makes sense but let's keep the link so know in the future it's good. |
SSE4
previously approved these changes
Apr 4, 2023
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
kambala-decapitator
dismissed stale reviews from SSE4 and grafikrobot
via
c58cd17
grafikrobot
approved these changes
Apr 4, 2023
SSE4
approved these changes
Apr 4, 2023
prince-chrismc
approved these changes
Apr 4, 2023
|
Boost needs to pass v2 for it to be mergable 🤔Not sure what broke |
that seems to be a wrong |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit c58cd17boost/1.79.0boost/1.81.0boost/1.78.0boost/1.71.0boost/1.80.0boost/1.70.0boost/1.76.0boost/1.75.0boost/1.74.0boost/1.73.0boost/1.77.0boost/1.72.0 |
Hopobcn
approved these changes
Apr 5, 2023
|
Conan v2 boost/1.75.0 failure seems related to numpy?
|
IIRC numpy error appears always, and it's not a fatal one - it's just a detection of numpy, and affects if boost_numpy module would be built or no. it shouldn't fail an entire build. it actually went further, but I don't see any actual error, the output looks truncated (like build timed out or was cancelled). |
|
still building after 18hrs |
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline (informative, not required for merge) ✔️
All green in build 4 (
|
MartinDelille
pushed a commit
to MartinDelille/conan-center-index
that referenced
this pull request
Apr 12, 2023
* Boost: use versionless soname on Android * Update recipes/boost/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> --------- Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: boost/all
Issue that I faced as written on Slack:
The proper solution is to tell Boost to use versionless soname, but unfortunately there's no such option. There's a pending PR in upstream boostorg/boost#206 for some years already, hopefully it'd be merged one day.
Using string replace should be safe as that line wasn't touched for many years:
and it can be used for any Boost version as that change was a part of v1.51 according to boostorg/boost@4ba4e16