Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automake: drop old version and recipe fixes #15023

Merged
merged 25 commits into from
Jan 25, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
44f0ae8
Automake Conan 2.0 compatibility
System-Arch Dec 30, 2022
d4113c4
Fixed lint and v1 issues
System-Arch Dec 30, 2022
039d525
Need autoconf for autoreconf
System-Arch Dec 31, 2022
dcf237c
Annotate patches per lint
System-Arch Dec 31, 2022
9e73483
Deleted spurious blank line at EOF
System-Arch Dec 31, 2022
dfecf39
Try working around v1 quirks
System-Arch Dec 31, 2022
28f09a9
Removed redundant setting of win_bash
System-Arch Jan 3, 2023
165f217
Don't specify env in call to self.run()
System-Arch Jan 3, 2023
a8d485a
See if reordering build requirements appeases Conan 1.x
System-Arch Jan 4, 2023
661f13c
Try adding VirtualBuildEnv to appease Conan 1.x
System-Arch Jan 4, 2023
b5cf16f
Bump required_conan_version to trigger rebuild now that autoconf has …
System-Arch Jan 13, 2023
9d530f5
Removed environment variables per discussion in conan-io/conan:#12812
System-Arch Jan 15, 2023
b63f393
Still need automake_dataroot_path
System-Arch Jan 15, 2023
606954f
Fixed definition of automake_dataroot_path
System-Arch Jan 15, 2023
ef62904
Replaced env. vars. with script-based paths
System-Arch Jan 16, 2023
b63cc9c
Removed extra blank line at EOF
System-Arch Jan 16, 2023
64b6607
Merge in changes from mainline
System-Arch Jan 16, 2023
f2f3519
Merge from mainline
System-Arch Jan 16, 2023
f018088
Remove obsolete patch files
System-Arch Jan 16, 2023
1bb1ae1
Bump required_conan_version
System-Arch Jan 17, 2023
f704319
Fixed lint warning
System-Arch Jan 20, 2023
fe8c61c
Merge branch 'master' into System-Arch-automake-1
System-Arch Jan 20, 2023
7eba669
Tweak required_conan_version() to restart CI after merge
System-Arch Jan 20, 2023
5e9bcb7
Removed autoconf as a build_requirement
System-Arch Jan 21, 2023
7fa1b39
Update recipes/automake/all/conanfile.py
prince-chrismc Jan 25, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replaced env. vars. with script-based paths
  • Loading branch information
System-Arch committed Jan 16, 2023
commit ef629045f24f35c40e721791c4a7d3709b7f9f97
16 changes: 0 additions & 16 deletions recipes/automake/all/conandata.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ sources:
"1.16.2":
url: "https://ftp.gnu.org/gnu/automake/automake-1.16.2.tar.gz"
sha256: "b2f361094b410b4acbf4efba7337bdb786335ca09eb2518635a09fb7319ca5c1"
"1.16.1":
url: "https://ftp.gnu.org/gnu/automake/automake-1.16.1.tar.gz"
sha256: "608a97523f97db32f1f5d5615c98ca69326ced2054c9f82e65bade7fc4c9dea8"
patches:
"1.16.5":
- patch_file: "patches/0001-help2man-no-discard-stderr-0.16.4.patch"
Expand Down Expand Up @@ -67,16 +64,3 @@ patches:
- patch_file: "patches/0004-introduce-automake_perllibdir-0.16.2.patch"
patch_description: "introduce automake perllibdir"
patch_type: "portability"
"1.16.1":
- patch_file: "patches/0001-help2man-no-discard-stderr-0.16.1.patch"
patch_description: "help2man no discard stderr"
patch_type: "portability"
- patch_file: "patches/0002-no-perl-path-in-shebang-0.16.1.patch"
patch_description: "no perl path in shebang"
patch_type: "portability"
- patch_file: "patches/0003-remove-embedded-datadirs-introduce-automake-conan-includes-0.16.1.patch"
patch_description: "remove embedded datadirs"
patch_type: "portability"
- patch_file: "patches/0004-introduce-automake_perllibdir-0.16.1.patch"
patch_description: "introduce automake perllibdir"
patch_type: "portability"

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
--- bin/aclocal.in
+++ bin/aclocal.in
@@ -62,8 +62,8 @@
@@ -62,8 +62,10 @@
# ACLOCAL_PATH environment variable, and reset with the '--system-acdir'
# option.
my @user_includes = ();
-my @automake_includes = ('@datadir@/aclocal-' . $APIVERSION);
-my @system_includes = ('@datadir@/aclocal');
+my @automake_includes = ($ENV{"AUTOMAKE_DATADIR"} . '/aclocal-' . $APIVERSION);
+my @system_includes = ($ENV{"AUTOMAKE_DATADIR"} . '/aclocal');
+my $scriptpath = abs_path(dirname(__FILE__));
+my @automake_includes = "$scriptpath/../res/aclocal-$APIVERSION";
+my @system_includes = "$scriptpath/../res/aclocal";
+my @conan_includes = uniq(split(/[:;]/, $ENV{'AUTOMAKE_CONAN_INCLUDES'} || ""));
-
# Whether we should copy M4 file in $user_includes[0].
my $install = 0;
@@ -445,6 +445,6 @@
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
--- bin/aclocal.in
+++ bin/aclocal.in
@@ -65,8 +65,8 @@
@@ -65,8 +65,10 @@
# ACLOCAL_PATH environment variable, and reset with the '--system-acdir'
# option.
my @user_includes = ();
-my @automake_includes = ('@datadir@/aclocal-' . $APIVERSION);
-my @system_includes = ('@datadir@/aclocal');
+my @automake_includes = ($ENV{"AUTOMAKE_DATADIR"} . '/aclocal-' . $APIVERSION);
+my @system_includes = ($ENV{"AUTOMAKE_DATADIR"} . '/aclocal');
+my $scriptpath = abs_path(dirname(__FILE__));
+my @automake_includes = "$scriptpath/../res/aclocal-$APIVERSION";
+my @system_includes = "$scriptpath/../res/aclocal";
+my @conan_includes = uniq(split(/[:;]/, $ENV{'AUTOMAKE_CONAN_INCLUDES'} || ""));
-
# Whether we should copy M4 file in $user_includes[0].
my $install = 0;
@@ -448,6 +448,6 @@
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,23 +1,34 @@
--- bin/aclocal.in
+++ bin/aclocal.in
@@ -21,7 +21,8 @@
@@ -20,8 +20,13 @@
# Alexandre Duret-Lutz <adl@gnu.org>.

+use Cwd 'abs_path';
+use File::Basename;
+
BEGIN
{
- unshift (@INC, '@datadir@/@PACKAGE@-@APIVERSION@')
+ my $pkgdatadir = $ENV{"AUTOMAKE_PERLLIBDIR"} || '@datadir@/@PACKAGE@-@APIVERSION@';
+ my $scriptpath = abs_path(dirname(__FILE__));
+ my $pkgdatadir = "$scriptpath/../@datadir@/@PACKAGE@-@APIVERSION@";
+ unshift (@INC, $pkgdatadir)
unless $ENV{AUTOMAKE_UNINSTALLED};
}

--- bin/automake.in
+++ bin/automake.in
@@ -26,7 +26,8 @@
@@ -25,8 +25,14 @@
use strict;

+use Cwd 'abs_path';
+use File::Basename;
+
BEGIN
{
- unshift (@INC, '@datadir@/@PACKAGE@-@APIVERSION@')
+ my $pkgdatadir = $ENV{"AUTOMAKE_PERLLIBDIR"} || '@datadir@/@PACKAGE@-@APIVERSION@';
+ my $scriptpath = abs_path(dirname(__FILE__));
+ $ENV{'AUTOMAKE_LIBDIR'} = "$scriptpath/../@datadir@/@PACKAGE@-@APIVERSION@" if ! exists $ENV{'AUTOMAKE_LIBDIR'};
+ my $pkgdatadir = "$scriptpath/../@datadir@/@PACKAGE@-@APIVERSION@";
+ unshift (@INC, $pkgdatadir)
unless $ENV{AUTOMAKE_UNINSTALLED};

Expand Down
Original file line number Diff line number Diff line change
@@ -1,23 +1,34 @@
--- bin/aclocal.in
+++ bin/aclocal.in
@@ -25,7 +25,8 @@

@@ -24,8 +24,13 @@
use warnings FATAL => 'all';

+use Cwd 'abs_path';
+use File::Basename;
+
BEGIN
{
- unshift (@INC, '@datadir@/@PACKAGE@-@APIVERSION@')
+ my $pkgdatadir = $ENV{"AUTOMAKE_PERLLIBDIR"} || '@datadir@/@PACKAGE@-@APIVERSION@';
+ my $scriptpath = abs_path(dirname(__FILE__));
+ my $pkgdatadir = "$scriptpath/../@datadir@/@PACKAGE@-@APIVERSION@";
+ unshift (@INC, $pkgdatadir)
unless $ENV{AUTOMAKE_UNINSTALLED};
}

--- bin/automake.in
+++ bin/automake.in
@@ -28,7 +28,8 @@
@@ -27,8 +27,14 @@
use warnings FATAL => 'all';

+use Cwd 'abs_path';
+use File::Basename;
+
BEGIN
{
- unshift (@INC, '@datadir@/@PACKAGE@-@APIVERSION@')
+ my $pkgdatadir = $ENV{"AUTOMAKE_PERLLIBDIR"} || '@datadir@/@PACKAGE@-@APIVERSION@';
+ my $scriptpath = abs_path(dirname(__FILE__));
+ $ENV{'AUTOMAKE_LIBDIR'} = "$scriptpath/../@datadir@/@PACKAGE@-@APIVERSION@" if ! exists $ENV{'AUTOMAKE_LIBDIR'};
+ my $pkgdatadir = "$scriptpath/../@datadir@/@PACKAGE@-@APIVERSION@";
+ unshift (@INC, $pkgdatadir)
unless $ENV{AUTOMAKE_UNINSTALLED};

Expand Down
3 changes: 1 addition & 2 deletions recipes/automake/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,4 @@ versions:
folder: all
"1.16.2":
folder: all
"1.16.1":
folder: all