Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the comments in the header-only template #14875

Conversation

AbrilRBS
Copy link
Member

Found some things in the header-only template that could use a rewording to better understand their message when I was playing around with this, so I changed some of those comments.

This also removes one important comment as a result of #14845

@prince-chrismc
Copy link
Contributor

You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 059b218 into conan-io:master Dec 22, 2022
@AbrilRBS AbrilRBS deleted the rr/improve-header-only-template-comments branch December 22, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants