mbits-args: conan v2 support #14866
Merged
mbits-args: conan v2 support #14866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mzdun
added a commit
to mzdun/conan-center-index
that referenced
this pull request
Dec 22, 2022
see review(s) in conan-io#14866
mzdun
added a commit
to mzdun/conan-center-index
that referenced
this pull request
Dec 22, 2022
see review(s) in conan-io#14866
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mzdun
requested review from
uilianries and
prince-chrismc
and removed request for
prince-chrismc and
uilianries
uilianries
approved these changes
Dec 22, 2022
Conan v1 pipelineAll green in build 8 (
Conan v2 pipeline (informative, not required for merge)All green in build 7 (
|
conan-center-bot
pushed a commit
that referenced
this pull request
Dec 26, 2022
* add mbits-semver/0.1.1 * up the minimium GCC version * fix: adding v1 config info * fix: bump min clang * remove unused imports * move msvc to the dict, clean package() see review(s) in #14866 * revert check_min_vs removal
conan-center-bot
pushed a commit
that referenced
this pull request
Dec 26, 2022
* add mbits-mstch/1.0.4 * move msvc to the dict, clean package() see review(s) in #14866 * revert check_min_vs removal
danimtb
approved these changes
Dec 27, 2022
Comment on lines
+39
to
+40
| options = {"fPIC": [True, False]} | ||
| default_options = {"fPIC": True} |
There was a problem hiding this comment.
Just as a future reference, we like to deprecate options before completely removing this to make it smoother for consumers 😄
The shared here should have been kept even though it's modified :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: mbits-args/0.12.3