-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix libressl build error with Visual Studio 2022 #14729
Conversation
This comment has been minimized.
This comment has been minimized.
Conan v1 pipelineAll green in build 2 (
|
@xyz1001 Please, pass it directly to cmake definition in the recipe, as we a middle of a migration to Conan v2. The CMake wrapper is no longer used on Conan v2 and soon should be deprecated. |
@uilianries I do not know how to add a C/C++ macro in the recipe. Is there any example? |
@xyz1001 No, because it should be patched to the upstream. Please, in case you identify a bug in the project, report directly to the upstream, so anyone, including the author, could have a proper hotfix. |
@uilianries This bug is fixed in libressl 3.5.x. But 3.0.2 may not be fixed. |
@xyz1001 No problem, you can apply a patch here in CCI too. Please, take a look about patch policy: https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/sources_and_patches.md#policy-about-patching |
Specify library name and version: libressl/3.0.2
Compiling libressl/3.0.2 with Visuao Studio 2022 will fail. Here are part of error output.