Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfgfile: add Conan v2 support, add version 0.2.11 #14662

Merged
merged 8 commits into from
Dec 15, 2022
Merged

cfgfile: add Conan v2 support, add version 0.2.11 #14662

merged 8 commits into from
Dec 15, 2022

Conversation

igormironchik
Copy link
Contributor

Specify library name and version: cfgfile/0.2.11

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


I'm the author of this library.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Dec 13, 2022
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

recipes/cfgfile/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cfgfile/all/conanfile.py Show resolved Hide resolved
recipes/cfgfile/all/test_package/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Dec 14, 2022
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@toge toge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be almost complete.
There are several minor issues, could you please fix them?

recipes/cfgfile/all/conanfile.py Outdated Show resolved Hide resolved
Comment on lines 73 to 76
tc.cache_variables["BUILD_EXAMPLES"] = False
tc.cache_variables["BUILD_TESTS"] = False
if Version(self.version) >= "0.2.9":
tc.cache_variables["USE_INTERNAL_ARGS_PARSER"] = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tc.cache_variables["BUILD_EXAMPLES"] = False
tc.cache_variables["BUILD_TESTS"] = False
if Version(self.version) >= "0.2.9":
tc.cache_variables["USE_INTERNAL_ARGS_PARSER"] = False
tc.variables["BUILD_EXAMPLES"] = False
tc.variables["BUILD_TESTS"] = False
if Version(self.version) >= "0.2.9":
tc.variables["USE_INTERNAL_ARGS_PARSER"] = False

Please use variables if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not possible in case of cfgfile. In my CMakeLists.txt options are set before project(), that is why I use cache_variables.

cmake_minimum_required( VERSION 3.19 )

set( CFGFILE_VERSION "0.2.11" )

option( BUILD_EXAMPLES "Build examples? Default ON." ON )
option( BUILD_TESTS "Build tests? Default ON." ON )

if( NOT CMAKE_BUILD_TYPE )
	set( CMAKE_BUILD_TYPE "Release"
		CACHE STRING "Choose the type of build."
		FORCE)
endif( NOT CMAKE_BUILD_TYPE )

SET( CMAKE_CXX_STANDARD 14 )

SET( CMAKE_CXX_STANDARD_REQUIRED ON )

project( cfgfile )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But with USE_INTERNAL_ARGS_PARSER I can use variables...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igormironchik
Thank you for your comment!
Now I agree with you!

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 6 (9a6187d62eb30a1d0a2c7baaff84eb951d78e719):

  • cfgfile/0.2.11@:
    All packages built successfully! (All logs)

  • cfgfile/0.2.9.0@:
    All packages built successfully! (All logs)

  • cfgfile/0.2.10@:
    All packages built successfully! (All logs)

  • cfgfile/0.2.8.2.1@:
    All packages built successfully! (All logs)

  • cfgfile/0.2.9.1@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 4c18d81 into conan-io:master Dec 15, 2022
@igormironchik igormironchik deleted the cfgfile_v.0.2.11 branch December 15, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants