-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cfgfile: add Conan v2 support, add version 0.2.11 #14662
cfgfile: add Conan v2 support, add version 0.2.11 #14662
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be almost complete.
There are several minor issues, could you please fix them?
recipes/cfgfile/all/conanfile.py
Outdated
tc.cache_variables["BUILD_EXAMPLES"] = False | ||
tc.cache_variables["BUILD_TESTS"] = False | ||
if Version(self.version) >= "0.2.9": | ||
tc.cache_variables["USE_INTERNAL_ARGS_PARSER"] = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tc.cache_variables["BUILD_EXAMPLES"] = False | |
tc.cache_variables["BUILD_TESTS"] = False | |
if Version(self.version) >= "0.2.9": | |
tc.cache_variables["USE_INTERNAL_ARGS_PARSER"] = False | |
tc.variables["BUILD_EXAMPLES"] = False | |
tc.variables["BUILD_TESTS"] = False | |
if Version(self.version) >= "0.2.9": | |
tc.variables["USE_INTERNAL_ARGS_PARSER"] = False |
Please use variables
if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not possible in case of cfgfile
. In my CMakeLists.txt
options are set before project()
, that is why I use cache_variables
.
cmake_minimum_required( VERSION 3.19 )
set( CFGFILE_VERSION "0.2.11" )
option( BUILD_EXAMPLES "Build examples? Default ON." ON )
option( BUILD_TESTS "Build tests? Default ON." ON )
if( NOT CMAKE_BUILD_TYPE )
set( CMAKE_BUILD_TYPE "Release"
CACHE STRING "Choose the type of build."
FORCE)
endif( NOT CMAKE_BUILD_TYPE )
SET( CMAKE_CXX_STANDARD 14 )
SET( CMAKE_CXX_STANDARD_REQUIRED ON )
project( cfgfile )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But with USE_INTERNAL_ARGS_PARSER
I can use variables
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@igormironchik
Thank you for your comment!
Now I agree with you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Conan v1 pipelineAll green in build 6 (
|
Specify library name and version: cfgfile/0.2.11
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
I'm the author of this library.