[ranges-v3] Fix issues with ranges-v3 recipe in Conan 2.0 #14628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcar87
changed the title
danimtb
previously approved these changes
Dec 7, 2022
prince-chrismc
previously approved these changes
Dec 7, 2022
jwillikers
previously approved these changes
Dec 7, 2022
SpaceIm
reviewed
Dec 7, 2022
prince-chrismc
dismissed stale reviews from jwillikers, danimtb, and themself
via
872b0c7
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
prince-chrismc
approved these changes
Dec 7, 2022
SpaceIm
reviewed
Dec 7, 2022
| @@ -67,7 +69,7 @@ def package(self): | |||
| def package_info(self): | |||
| self.cpp_info.components["range-v3-meta"].names["cmake_find_package"] = "meta" | |||
There was a problem hiding this comment.
I see that target names of components are wrong in CMakeDeps
Conan v1 pipelineAll green in build 2 (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: ranges-v3/all
Small fixes to support Conan v2
is_msvcto check for the Visual C++ compiler instead of testing for the compiler name, as Conan 2 will raise an error sinceVisual Studiowas removed in favour ofmsvcself.output.warninginstead ofwarnwhich is no longer in conan 2