Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmos-cpp/cci.20221203: new release and conan v2 migration #14553

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

garethsb
Copy link
Contributor

@garethsb garethsb commented Dec 3, 2022

Specify library name and version: nmos-cpp/cci.20221203

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 1 (4f72a87148336a263e2d0e20366f70e7dfe04aac):

  • nmos-cpp/cci.20220428@:
    All packages built successfully! (All logs)

  • nmos-cpp/cci.20220620@:
    All packages built successfully! (All logs)

  • nmos-cpp/cci.20221203@:
    All packages built successfully! (All logs)

  • nmos-cpp/cci.20220208@:
    All packages built successfully! (All logs)

  • nmos-cpp/cci.20220120@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good enough. The only thing I would suggest is simplifying the test package with something without networking, to avoid CI failures, like https://github.com/sony/nmos-cpp/blob/ab253f95259503bf96b24e0dcb3438753d832e5b/Development/nmos/version.h#L13. But it can be improved later .

@garethsb
Copy link
Contributor Author

garethsb commented Dec 5, 2022

Thanks, Uilian! Since nmos-cpp-registry is a tool provided by the package the test package should at least check it can run, I think, as well as having a simple compile/link/run test of the libraries.

@conan-center-bot conan-center-bot merged commit b8ab766 into conan-io:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants