-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#14500) Bump perfetto to v31.0 #14501
(#14500) Bump perfetto to v31.0 #14501
Conversation
Perfetto switches to C++17 standard and already breaks the compilation right now, so enable C++17 starting from this version and for all test packages to avoid overhead
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit b6a1892perfetto/30.0
perfetto/27.0
perfetto/25.0
perfetto/27.1
perfetto/24.2
perfetto/22.0
perfetto/26.1
perfetto/21.0
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 3cfca45perfetto/27.0
perfetto/24.2
perfetto/30.0
perfetto/22.1
perfetto/27.1
perfetto/26.1
perfetto/20.1
perfetto/22.0
|
@@ -4,5 +4,5 @@ project(test_package LANGUAGES CXX) | |||
find_package(perfetto REQUIRED CONFIG) | |||
|
|||
add_executable(${PROJECT_NAME} test_package.cpp) | |||
target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_11) | |||
target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_17) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we condition this based on the version? Otherwise if you're stuck on an old compiler which doesn't support GCC 17 you wont be able to consume this package anymore. You should at least be able to consume the older versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit fb1ac8cperfetto/27.0
perfetto/25.0
perfetto/30.0
perfetto/26.1
perfetto/24.2
perfetto/22.1
perfetto/27.1
perfetto/23.0
perfetto/20.1
perfetto/21.0
perfetto/22.0
perfetto/31.0
|
Conan v1 pipelineAll green in build 4 (
|
Perfetto switches to C++17 standard and already breaks the compilation right now, so enable C++17 starting from this version and for all test packages to avoid overhead
Specify library name and version: perfetto/31.0
Closes #14500