Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libdc1394: conan v2 support #14336

Merged
merged 1 commit into from
Dec 5, 2022
Merged

libdc1394: conan v2 support #14336

merged 1 commit into from
Dec 5, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Nov 21, 2022 •
edited
Loading

It should build, but needs #14335 to ensure to find libusb. So converted to draft for the moment.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@SpaceIm SpaceIm marked this pull request as draft November 21, 2022 13:05
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm marked this pull request as ready for review November 21, 2022 17:07
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 4 (d7b49bcc6cd946dc6a945f216c623f2edcc0b027):

  • libdc1394/2.2.6@:
    All packages built successfully! (All logs)

@github-actions github-actions bot mentioned this pull request Nov 21, 2022
Open
uilianries
uilianries approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit e650a18 into conan-io:master Dec 5, 2022
@SpaceIm SpaceIm deleted the libdc1394-conan-v2 branch December 5, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@jwillikers jwillikers jwillikers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SpaceIm @conan-center-bot @uilianries @jwillikers