Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icu: fix emscripten build for 71.1 #13890

Merged
merged 6 commits into from
Nov 11, 2022

Conversation

ovostrikov
Copy link
Contributor

@ovostrikov ovostrikov commented Oct 31, 2022

Specify library name and version: icu/71.1

Fixes #13888

There were bunch of underlying issues:

  • ICU didn't recognise wasm32-*-emscripten as a host (fixed with a patch).
  • ICU's autoconfig didn't properly recognize that we are cross-building (fixed by adding "--build=" parameter to build configuration in the recipe).
  • ICU tools needs to be disabled for emscripten (fixed in the recipe).
  • While packaging ICU data '-w' param needs to be passed in the PKGDATA_OPTS (fixed with a patch), because there is no pre-built assembly code for wasm

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Oct 31, 2022

I detected other pull requests that are modifying icu/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Oct 31, 2022
4 tasks
@ovostrikov ovostrikov changed the title Fix Emscripten build for ICU Fix Emscripten build for ICU/71.1 Oct 31, 2022
@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

This recipe is outdated and requires some tooling update, following https://github.com/conan-io/conan-center-index/blob/master/docs/v2_linter.md guide.

All annotations which requires update are listed on https://github.com/conan-io/conan-center-index/pull/13890/files

Could you please update those outdated imports? We can help you in case you need some support.

@ovostrikov ovostrikov closed this Nov 4, 2022
@ovostrikov ovostrikov reopened this Nov 4, 2022
@ovostrikov
Copy link
Contributor Author

ovostrikov commented Nov 4, 2022

Seems like tooling is fixed in #13877, so I was going to wait for its completion to avoid doing same job twice.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Nov 4, 2022
4 tasks
@ovostrikov ovostrikov changed the title Fix Emscripten build for ICU/71.1 icu: fix emscripten build for 71.1 Nov 10, 2022
@prince-chrismc
Copy link
Contributor

Please do not force push 🙏 GitHub forces us to restart the review which is not fun!

@prince-chrismc
Copy link
Contributor

A build agent hung

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 8 (66288da989effec89652ca9dc8f7c53b8d606c2e):

  • icu/72.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py", line 8, in <module>
        from conans import AutoToolsBuildEnvironment
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • icu/71.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py", line 8, in <module>
        from conans import AutoToolsBuildEnvironment
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • icu/70.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py", line 8, in <module>
        from conans import AutoToolsBuildEnvironment
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • icu/69.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py", line 8, in <module>
        from conans import AutoToolsBuildEnvironment
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • icu/66.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py", line 8, in <module>
        from conans import AutoToolsBuildEnvironment
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • icu/67.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py", line 8, in <module>
        from conans import AutoToolsBuildEnvironment
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • icu/68.2@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py", line 8, in <module>
        from conans import AutoToolsBuildEnvironment
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • icu/65.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13890/recipes/icu/all/conanfile.py", line 8, in <module>
        from conans import AutoToolsBuildEnvironment
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

@conan-center-bot conan-center-bot merged commit 2171226 into conan-io:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] ICU/71.1: can't be built with emscripten
4 participants