lief: add version 0.12.2 #13660
Merged
lief: add version 0.12.2 #13660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 21, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jwillikers
previously approved these changes
Oct 22, 2022
recipes/lief/all/conanfile.py
Outdated
| apply_conandata_patches(self) | ||
|
|
||
| # dirty fix for compilation error on gcc 5 |
There was a problem hiding this comment.
This should be a patch and upstreamed 🙈
There was a problem hiding this comment.
@prince-chrismc
Thanks.
I created PR for it.
There was a problem hiding this comment.
Can you please move this out of the recipe, with a "patch_source" field point to you PR 🙏 this way it will be easier to track and bump version when this patch is accepted
There was a problem hiding this comment.
@prince-chrismc
I see.
I am going to create additional patch for it.
jwillikers
approved these changes
Oct 25, 2022
uilianries
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lief/0.12.2