lmdb: conan v2 support #13560
Merged
lmdb: conan v2 support #13560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
jwillikers
previously approved these changes
Oct 18, 2022
| WINDOWS_EXPORT_ALL_SYMBOLS ON | ||
| ) | ||
|
|
||
| include(FindThreads) | ||
| target_link_libraries(lmdb PUBLIC ${CMAKE_THREAD_LIBS_INIT}) | ||
| find_package(Threads REQUIRED) |
There was a problem hiding this comment.
Setting THREADS_PREFER_PTHREAD_FLAG to true before find_package(Threads ...) is recommended by CMake's documentation.
There was a problem hiding this comment.
I'm not sure whether it's really required. Most CMakeLists don't add this variable. It's required only if you have to pass -pthread to compiler.
| cmake_layout(self) | ||
|
|
||
| def requirements(self): | ||
| self.requires(self.tested_reference_str) | ||
|
|
||
| def build(self): | ||
| cmake = CMake(self) | ||
| cmake.configure() | ||
| cmake.build() | ||
|
|
||
| def test(self): |
There was a problem hiding this comment.
adding path but not running any tools? seems a little odd
There was a problem hiding this comment.
test_package is listed there
There was a problem hiding this comment.
What is in the bin path that needs to be exposed? Should we not test that it works?
If this is only libraries then the recipe is confusing me
There was a problem hiding this comment.
Ok I see what you mean. It's out of scope of this PR, it was not tested before anyway (like almost all CCI recipes actually...).
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
|
All green in build 2 (
|
uilianries
approved these changes
Oct 18, 2022
jwillikers
approved these changes
Oct 18, 2022
planetmarshall
added a commit
to planetmarshall/conan-center-index
that referenced
this pull request
Sep 3, 2024
conan-center-bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
* [llvm-core] bring package up to date. Initial support for 13.0.0 * [llvm-core] add support for job pool resource limits from @jusito * [llvm-core] add cmake patch for 12.0.0 * [llvm-core] add cmake patch for 11.1.0 * [llvm-core] allow conan 1.x * [llvm-core] fix zlib detection for 11.1.0 * [llvm-core] additional patches for missing includes and patch metadata * [llvm-core] resolve v1 hooks issues * [llvm-core] use llvm generated config file to extract components * [llvm-core] add custom cmake build script * [llvm-core] use run env during build and force ninja * [llvm-core] fix patches for libxml * [llvm-core] bump up default ram per link job * [llvm-core] backport split-dwarf patches from 14.x * [llvm-core] add support for cross compiling * [llvm-core] fix patch files for split dwarf * [llvm-core] disable cross compilation * [llvm-core] add CCI build service specific behaviour * [llvm-core] fix cci resource limitations * [llvm-core] implement component dependencies * [llvm-core] sanitize component names * [llvm-core] bump ram per link job for cci shared debug * [llvm-core] exclude cmake find modules * [llvm-core] skip rpath on macos * [llvm-core] reformat and fix linting issues * [llvm-core] delete 18x patch (added in error) * [llvm-core] rename references to LLVM-Config * [llvm-core] retain LLVMConfigExtensions.cmake * [llvm-core] add fake targets for *-gen * [llvm-core] use the actual cmake target name as component name * [llvm-core] fix component dependencies * [llvm-core] add target options * [llvm-core] add editline requirement (WIP) * [llvm-core] support for libedit (editline) in 13.x * [llvm-core] disable shared debug for CCI, update license identifier and refactor * [llvm-core] require cxx std 14 for test package * [llvm-core] handle edge case of static libiconv being linked into a dynamic library on macos * [llvm-core] skip rpath handling for build on macos * [llvm-core] propagate DYLD_LIBRARY_PATH to tblgen during build * [llvm-core] propagate DYLD_LIBRARY_PATH to tblgen during build * [llvm-core] do not build shared libs with the install rpath * [llvm-core] use original test package * [llvm-core] do not package static libraries with shared build * [llvm-core] fix test_package * [llvm-core] support linking in lib for native codegen * [llvm-core] add windows support * [llvm-core] remove pdb files * [llvm-core] require cmake_path support in test package * [llvm-core] handle legacy conan msvcrt setting * [llvm-core] missing patch type * Apply suggestions from code review Co-authored-by: Michael Keck <git@cr0ydon.com> * [llvm-core] revert changes to license * [llvm-core] apply review suggestions * [llvm-core] add patch source for include file fix * [llvm-core] use user-config for compiler resource settings * [llvm-core] add link for further info on cross compilation * [llvm-core] use PurePosixPath only * Trying 'as_posix()' function * More 'as_posix()' function * Typo * [llvm-core] revert usage of 'load' to workaround regex error * [llvm-core] try relaxing restrictions on cross-building * [llvm-core] use semi-colon separated string for targets instead of individual options * [llvm-core] set default fPIC fallback to 'True' * [llvm-core] use version range for ninja * [llvm-core] move cci check to 'validate_build' * [llvm-core] allow CCI to use llvm-core user config for resource limits * [llvm-core] dont activate build environment for llvm-tblgen * [llvm-core] add patch for link failure with lld * [llvm-core] explicitly list shared libraries * [llvm-core] revert to using * Revert "[llvm-core] try relaxing restrictions on cross-building" This reverts commit 7b2e085 * [llvm-core] workaround for #13560 * [llvm-core] increase ram available for link jobs in CCI * [llvm-core] remove the split-dwarf patch * [llvm-core] disable shared debug builds entirely and debug builds for linux * [llvm-core] remove remaining split-dwarf capability --------- Co-authored-by: Michael Keck <git@cr0ydon.com> Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!