Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qt] Shouldn't include license glob files for examples #19767

Closed
mrjoel opened this issue Sep 13, 2023 · 1 comment · Fixed by #19768
Closed

[qt] Shouldn't include license glob files for examples #19767

mrjoel opened this issue Sep 13, 2023 · 1 comment · Fixed by #19768
Labels
bug Something isn't working

Comments

@mrjoel
Copy link
Contributor

mrjoel commented Sep 13, 2023 •
edited
Loading

Description

The license inclusion rule for the qt packages (5.x and 6.x) overzealously include files matching the license glob. In particular, this ends up including the following matching files, even though examples are excluded (Example from Qt 5.15.10).

licenses/qtbase/examples/widgets/dialogs
licenses/qtbase/examples/widgets/dialogs/licensewizard
licenses/qtbase/examples/widgets/dialogs/licensewizard/licensewizard.h
licenses/qtbase/examples/widgets/dialogs/licensewizard/licensewizard.qrc
licenses/qtbase/examples/widgets/dialogs/licensewizard/licensewizard.pro
licenses/qtbase/examples/widgets/dialogs/licensewizard/main.cpp
licenses/qtbase/examples/widgets/dialogs/licensewizard/licensewizard.cpp
licenses/qtbase/examples/widgets/dialogs/licensewizard/images
licenses/qtbase/examples/widgets/dialogs/licensewizard/images/watermark.png
licenses/qtbase/examples/widgets/dialogs/licensewizard/images/logo.png
licenses/qtbase/examples/widgets/doc
licenses/qtbase/examples/widgets/doc/src
licenses/qtbase/examples/widgets/doc/src/licensewizard.qdoc
licenses/qtbase/examples/widgets/tools
licenses/qtbase/examples/widgets/tools/settingseditor
licenses/qtbase/examples/widgets/tools/settingseditor/inifiles
licenses/qtbase/examples/widgets/tools/settingseditor/inifiles/licensepage.ini

Package and Environment Details

  • Conan version: conan 1.60.2

Conan profile

[settings]

Steps to reproduce

Build qt 5.x.x recipe

Logs

(manual inspection of package in Conan cache)
@mrjoel mrjoel added the bug Something isn't working label Sep 13, 2023
@mrjoel
Copy link
Contributor Author

mrjoel commented Sep 13, 2023 •
edited
Loading

MR submitted at #19768

mrjoel added a commit to mrjoel/conan-center-index that referenced this issue Sep 13, 2023
@mrjoel
(conan-io#19767) qt: exclude examples from license pattern
439299b 
Don't include license files for examples when the example content is not
built.
mrjoel added a commit to mrjoel/conan-center-index that referenced this issue Sep 13, 2023
@mrjoel
(conan-io#19767) qt: exclude examples from license pattern
e8324bb 
Don't include license files for examples when the example content is not
built.

Fixes: conan-io#19767
@mrjoel mrjoel mentioned this issue Sep 13, 2023
Open
@AbrilRBS AbrilRBS mentioned this issue Sep 14, 2023
Merged
@AbrilRBS AbrilRBS linked a pull request Sep 15, 2023 that will close this issue
(#19767) qt: exclude examples from license pattern #19768
Merged
3 tasks
conan-center-bot pushed a commit that referenced this issue Oct 26, 2023
@mrjoel @AbrilRBS
(#19768) (#19767) qt: exclude examples from license pattern
128a07e 
* (#19767) qt: exclude examples from license pattern

Don't include license files for examples when the example content is not
built.

Fixes: #19767

* Bump brotli

---------

Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#19767) qt: exclude examples from license pattern mrjoel/conan-center-index
1 participant
@mrjoel