support list in conan command during version check #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
memsharded
reviewed
Aug 28, 2024
There was a problem hiding this comment.
Thanks for your contribution @oleksandr-prykhodko-quickbase
memsharded
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
I think I am fine with this change, but will assign @jcar87 to review.
Thanks for your contribution @oleksandr-prykhodko-quickbase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have custom wrapper around
conancommand and use it in cmake asset(CONAN_COMMAND "py;conan_command.py")Passing it to
conan_get_versionunwraps it as a list thus version check calls whatever is first in the list instead of the whole command.