Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore "unreachable" false-positives from mypy #142

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jan 11, 2022

A bug in mypy's new unreachability-detection algorithm led to several false-positives when type-checking. This PR instructs mypy to just ignore what it thinks are errors.

@jwodder jwodder added the tests Add or improve existing tests label Jan 11, 2022
@jwodder jwodder mentioned this pull request Jan 11, 2022
@yarikoptic
Copy link
Member

cool, thanks for the reference to the original issue! IMHO it would be useful to have that reference either in commit message or in a single use spot as a comment, so later we do not need to do much of investigation to figure out why those ignores and either it is time to remove them.

@jwodder
Copy link
Member Author

jwodder commented Jan 11, 2022

@yarikoptic Reference added to commit message.

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2022

Codecov Report

Merging #142 (ba72e85) into master (23bcccc) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   70.97%   70.87%   -0.11%     
==========================================
  Files          10       10              
  Lines         975      975              
  Branches      179      179              
==========================================
- Hits          692      691       -1     
- Misses        226      230       +4     
+ Partials       57       54       -3     
Impacted Files Coverage Δ
src/tinuous/github.py 51.56% <0.00%> (-1.35%) ⬇️
src/tinuous/__main__.py 53.47% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23bcccc...ba72e85. Read the comment docs.

@yarikoptic
Copy link
Member

Thank you!

@yarikoptic yarikoptic merged commit 24bcb20 into master Jan 11, 2022
@yarikoptic yarikoptic deleted the fix-typing branch January 11, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants