Skip to content

Remove extra function wrap#170

Open
unional wants to merge 1 commit into
computmaxer:masterfrom
unional:master
Open

Remove extra function wrap#170
unional wants to merge 1 commit into
computmaxer:masterfrom
unional:master

Conversation

@unional

@unional unional commented Jul 18, 2016

Copy link
Copy Markdown

Fix #169

System.import() returns a promise.
.then() accepts a promise in return, not a function.

@aviary-wf

Copy link
Copy Markdown

Raven

Number of Findings: 0

@unional

unional commented Jul 18, 2016

Copy link
Copy Markdown
Author

karma.start() was being called automatically when certain time has passed, not from this line:
https://github.com/Workiva/karma-jspm/blob/master/src/adapter.js#L65

If you added console.log('karma.start())` to it, you can see it is not being called.

This is because after the first call, the promiseChain resolved to a function with other System.import() calls, so they are "detached" and not tracked.

@3cp

3cp commented Aug 14, 2017

Copy link
Copy Markdown

Why there is no follow up for this much needed fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants