Finish parser for Jack grammar #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The book talks about the contract being that when you enter a method `compile_xxxx` you are already looking at the first token being valid for an `xxxx`. So, the behaviour should be to `advance then check`, always, instead of our `check(peek) then advance then check`. It also says that we should always leave a `compile_xxxx` method by advancing past the `xxxx`, which actually then works out nicely for continued compilation.
…compile ExpressionlessSquare::SquareGame
|
Discussed at Meeting 11. |
leocassarani
added a commit
that referenced
this pull request
Jun 16, 2015
Finish parser for Jack grammar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the updates to our current parser that I mentioned in email. It parses all files as expected and adds another smaller test for a few other untested grammar rules.
First commit makes a potentially controversial revert, so that might be worth glancing over. I feel there's less to mentally track without the 'do I need to peek or move here?' decisions which kept leading us to infinite loops.
Smaller unit tests would still be useful if anyone feels the urge, or wrapping an executable, I have skipped on both 😞
As an aside, a potential refactor that I haven't touched is that we don't really need to specify
Tokenizer::FOOforconsumeas our grammar has a uniquetoken_typepertoken_text, i.e.thiscan never be an identifier (or our tokenizer is wrong), so we could justconsume('blah')orconsume_identifieretc which would remove a lot of the noise while still failing if unexpected things pop up.