Incompatible with coverage 5.0

[goerz]

It seems like nbval does not work with the just released coverage 5.0 package: https://travis-ci.org/qucontrol/krotov/jobs/625049383

[eric-wieser]

The error is:

    def _make_suffix(cov):
        """Create a suffix for nbval data file depending on pytest-cov config."""
        # Check if coverage object has data_suffix:
>       if cov and cov.data_suffix is not None:
E       AttributeError: 'Coverage' object has no attribute 'data_suffix'

Caused by

nbval/nbval/cover.py

Lines 112 to 122 in 7c6cd71

	def _make_suffix(cov):
	"""Create a suffix for nbval data file depending on pytest-cov config."""
	# Check if coverage object has data_suffix:
	if cov and cov.data_suffix is not None:
	# If True, the suffix will be autogenerated by coverage.py.
	# The suffixed data files will be automatically combined later.
	if cov.data_suffix is True:
	return True
	# Has a suffix, but we add our own extension
	return cov.data_suffix + '.nbval'
	return 'nbval'

[takluyver]

PR #130 pins the version of coverage to avoid this problem. But we should work out a proper fix and unpin it again, so I'll leave this issue open.

[eric-wieser]

See nedbat/coveragepy#882 (comment) for more information

[mloubout]

Hello, we ran into issue in our CI due to the new coverage < 5.0 requirement that make our installation crash. Is there any timeline concerning that issue?

[mloubout]

Any update on this one?

[vidartf]

I had a look again to figure out what the code is doing. Basically, the code is trying to tell whether we are being run with the Central pytest-cov engine, or the DistWorker (previously DistSlave) pytest-cov engine.

The easiest solution is probably to say "we only support the central engine", and get rid of this code.

[vidartf]

Looking at it further, it might just be best to drop the coverage support.

[eric-wieser]

Dropping support for coverage entirely would be a real shame :(

[vidartf]

I made a fix PR, but its all dependent on pytest-cov remaining somewhat stable.

[goerz]

For what it’s worth, I depend on coverage reports including code that ran only due to nbval (alongside “normal” tests). So I very much hope you’re not dropping coverage support.

[vidartf]

@goerz Would you be able to test that the PR (#134) works as expected for you?

[goerz]

I'll give it a try soon...

[goerz]

Looks good! 👍

[vidartf]

Released as 0.9.5