Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace delete() with put(0) - delete is broken for forked vms #5

Open
wants to merge 2 commits into
base: compound
Choose a base branch
from
+49 −8
Open

Replace delete() with put(0) - delete is broken for forked vms #5

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dedde89
Replace delete() with put(0) - delete is broken for forked vms
jflatow Mar 11, 2020
4c7e063
Add a minimal test for the patch
jflatow May 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Replace delete() with put(0) - delete is broken for forked vms
  • Loading branch information
@jflatow
jflatow committed May 21, 2020
commit dedde897adc9884616317af29f8d55e0ee47bca4
9 changes: 1 addition & 8 deletions lib/utils/forkedstoragetrie.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,8 @@ ForkedStorageBaseTrie.prototype.keyIsDeleted = function(key, callback) {
});
};

const originalDelete = ForkedStorageBaseTrie.prototype.del;
ForkedStorageBaseTrie.prototype.del = function(key, callback) {
let rpcKey = to.rpcDataHexString(key);
if (this.address) {
rpcKey = `${to.rpcDataHexString(this.address)};${rpcKey}`;
}
this._deleted.put(rpcKey, 1, () => {
originalDelete.call(this, key, callback);
});
this.put(key, 0, callback);
};

ForkedStorageBaseTrie.prototype.copy = function() {
Expand Down