Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the CErc20Delegator back to slightly less optimized version #48

Closed
wants to merge 1 commit into from

Conversation

jflatow
Copy link
Contributor

@jflatow jflatow commented Aug 19, 2020

Addresses #39 by reverting the contract to the previous form used by cDAI.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2020

Codecov Report

Merging #48 into master will decrease coverage by 1.74%.
The diff coverage is 48.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   50.38%   48.63%   -1.75%     
==========================================
  Files          47       42       -5     
  Lines        4077     3979      -98     
  Branches      515      506       -9     
==========================================
- Hits         2054     1935     -119     
- Misses       2023     2044      +21     
Impacted Files Coverage Δ
contracts/CErc20Delegator.sol 68.99% <48.43%> (+26.24%) ⬆️
contracts/CToken.sol 70.97% <0.00%> (-11.02%) ⬇️
tests/Contracts/ComptrollerHarness.sol 47.29% <0.00%> (-10.35%) ⬇️
contracts/CErc20.sol 72.88% <0.00%> (-3.39%) ⬇️
tests/Contracts/CErc20Harness.sol 28.29% <0.00%> (-0.98%) ⬇️
tests/Contracts/Structs.sol
tests/Contracts/Const.sol
tests/Contracts/MockMCD.sol
contracts/DAIInterestRateModelV3.sol
contracts/JumpRateModelV2.sol
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b3fbb...4d770d3. Read the comment docs.

@jflatow
Copy link
Contributor Author

jflatow commented Aug 19, 2020

These coverage drops should be addressed for a new cToken

@hayesgm
Copy link
Collaborator

hayesgm commented Aug 24, 2020

I think coverage looks pretty good here

@jflatow
Copy link
Contributor Author

jflatow commented Sep 14, 2020

This PR exists for the sake of deployers of future cTokens (linked elsewhere, does not need to remain open).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants