Use viaIR #218
Merged
Use viaIR #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincheng96
approved these changes
Mar 8, 2022
|
🕵️ |
scott-silver
approved these changes
Mar 8, 2022
jflatow
force-pushed
the
jflatow/via-ir
branch
4 times, most recently
from
0a06411
to
21f9010
Compare
jflatow
force-pushed
the
jflatow/via-ir
branch
4 times, most recently
from
b476c68
to
ad1e0d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now breaks coverage due to the coverage strategy of modifying the contracts combined with viaIR compilation. We had another strategy for coverage in saddle using the 0x monorepo to build https://www.npmjs.com/package/@compound-finance/sol-coverage, which should work better. We'll probably end up building a hardhat plugin around that so we can use it again.