notify-batch key, rebase #246 #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->root = $this->setFileSystem(); | ||
| } | ||
|
|
||
| protected function setFileSystem() |
There was a problem hiding this comment.
It's better to make this method return the filesystem stream instance. Using side-effects (e.g. changing state instead of returning something) is generally a bad idea.
There was a problem hiding this comment.
Well, ok about side-effect/change state, but I didn't find a way to change the code that way. Then, i simplified removing the method...
|
Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #66 and #246 + Unit tests